TheWinABagel / Zenith

An unofficial fabric port of Apotheosis
https://www.curseforge.com/minecraft/mc-mods/zenith
MIT License
18 stars 21 forks source link

Silk touch not dropping the spawner - Zenith 1.1.7 [Fabric] #142

Open Alysscendre opened 8 months ago

Alysscendre commented 8 months ago

Modpack Version / Modpack : Latest beta of this pack Mods version : Zenith-1.1.7-1.20.1.jar / Zenith_attributes-0.2.2.jar

Issue Description: Spawners don't drop with silk touch

Reproduction Steps: Step 1. get a silk touch pickaxe ( We tried vanilla [Diamond & Netherite] and modded ones ) Step 2. mine a spawner ( Natural or creative spawned + egg ones )

What did we check / test :

image image

Don't hesitate to let me know if you need anything else !

trunksbomb commented 7 months ago

https://github.com/TheWinABagel/Zenith/blob/eb5e5cda1bac1d003c8966a0731d37acd0061151/src/main/java/dev/shadowsoffire/apotheosis/mixin/spawn/SpawnerBlockMixin.java#L68

It's because that block of code isn't getting called at all. So there's a starting point, at least.

singulantlive commented 7 months ago

Im having this issue as well. If the code isnt getting called that seems like the issue, dead and done. Do we know if and when it will be patched?

trunksbomb commented 7 months ago

I looked into submitting a PR a couple weeks ago but I just couldn't find where in the code it was supposed to be called but wasn't. Asked in the Fabric modding Discord and didn't get a great answer either. 🤷

DraGonFiirE commented 4 months ago

This is still a problem in 1.20.1