search

TheWinABagel / Zenith

An unofficial fabric port of Apotheosis
https://www.curseforge.com/minecraft/mc-mods/zenith
MIT License
16 stars 18 forks source link

Issue with Gem Attributes Not Being Added and ZENITH_REMOVE_MARKER in Attributes #191

Open TheEndZM opened 1 month ago

TheEndZM commented 1 month ago

Dear Developer,

I encountered an issue while using the mod. Here are the details:

  1. I placed a gem and a piece of equipment on the forging table. However, the gem's attributes were not added to the equipment, and the gem was consumed in the process.

  2. Additionally, I noticed a new line in my attributes that says: ZENITH_REMOVE_MARKER. I am unsure what this means and if it is related to the issue mentioned above.

Could you please help me understand and resolve these issues?

Thank you for your assistance.

Best regards No 1 No 2 No 3

AgentK20 commented 1 week ago

I did some debugging on this just now and it looks to me like zenith$gatherComponents isn't even being called! I notice that, based on your screenshot @TheEndZM , you're using Modern UI (I think?). I am too. I'm going to try removing it and see if that fixes it.

AgentK20 commented 1 week ago

Aha! Yep! Removing Modern UI fixes it! I'm going to take a swing at trying to restructure this code to modify the itemstack itself rather than trying to inject itself into the GUI code, so that it will be compatible with UI mods like this.