search

TheWinABagel / Zenith

An unofficial fabric port of Apotheosis
https://www.curseforge.com/minecraft/mc-mods/zenith
MIT License
16 stars 19 forks source link

StackOverflowError with certain mod combinations #206

Closed AgentK20 closed 2 months ago

AgentK20 commented 2 months ago

Zenith Version: 1.2.3-1.20.1 Fabric Loader Version: 1.15.11 Minecraft: 1.20.1 Fabric API: 0.92.2+1.20.1

Crash log: https://mclo.gs/3s2y9RE

I'm building a new modpack and had things pretty stable, but when I added Spellblades and Such and its dependencies (Extra RPG Attributes, AzureLib, Spell Engine, and Runes). The mixin that seems to be causing the problem is from Extra RPG Attributes, specifically here. That said, their mixin seems pretty tame, so I dug into Zenith's side of the loop.

Looking through the in Zenith, I'm seeing that LootCategory's ShieldBreakerTest seems to be doing some somewhat dubious checks here. I'm not exactly sure what the overall intent of these few lines is, but calling LivingEntity#setItemInHand from within a Loot Predicate seems like it'll almost always be a bad idea that can cause recursion like seen in this crash. Is there a better way to handle this LootCategory test?

AgentK20 commented 2 months ago

Just realized this is a duplicate of #182. Didn't notice it in my search because it doesn't mention the keyword I searched for (Overflow)