TheWinABagel / ZenithAttributes

A port of Apotheosis attributes to fabric
MIT License
2 stars 5 forks source link

Remove Projectile Damage Attribute and add ARROW_DAMAGE #30

Closed muon-rw closed 1 month ago

muon-rw commented 2 months ago

Instead of migrating to Ranged Weapon API, ZenithAttributes should simply create its own implementation for AttributesLib's ARROW_DAMAGE in a compatible way.

ARROW_DAMAGE has slightly unexpected behavior/range, being indexed at 1.0 and functioning as a multiplier for arrow damage, unlike Projectile Damage/RangedWeapon API whose damage attributes are the total base value.

This discrepancy is the partial cause for https://github.com/muon-rw/Zephyr/issues/6 and https://github.com/TheWinABagel/Zenith/issues/169 due to the values of this affix

Implementation:

Tested on skeletons and player, seems to work well