TheXTech / TheXTech

The full port of the SMBX engine from VB6 into C++ and SDL2, FreeImage and MixerX
https://wohlsoft.ru/projects/TheXTech/
GNU General Public License v3.0
286 stars 28 forks source link

[ Feature Request ] - Optional Voice FX Support #263

Closed ChristianSilvermoon closed 7 months ago

ChristianSilvermoon commented 2 years ago

I feel like this one might be a bit decisive... as I know some really do not like the voices... but I grew up playing Super Mario All Stars on SNES, and then eventually the Super Mario Advance games on GBA. It had been really satisfying to have them portable and to have the voice clips... they added just a bit more personality to things.

I think it would be really neat to have support for having the same in TheXTech (though perhaps not enabled by default since I know some really don't like it... plus it would be extra assets to load which might not be so ideal on lower end platforms)

If such a feature were added, I think it'd be good if it was also made with #261 in mind, so that costumes could also change the voice clips (or disable them) since they may not be ideal for certain costumes, or certain costumes may have a more appropriate alternative sounds.

vitzie629 commented 2 years ago

I would find the optional voice effects support for Mario, Luigi, Peach, Toad, and Link in SMBX to be very fascinating to me because it would give consistency with modern Nintendo games in SMBX!

Wohlstand commented 2 years ago

You may don't worry as Sound FX feature I made, will never work implicitly until episode maker will add it's usage explicitly 😉

Damn my phone and attention through the sleep, confused the topic

Wohlstand commented 2 years ago

I guess, there are could be an additional set of sounds added into the same bank, and will be played when special hooks (intended to play voices) will be handled

vitzie629 commented 2 years ago

I guess, there are could be an additional set of sounds added into the same bank, and will be played when special hooks (intended to play voices) will be handled

An additional set of sounds like what?

Wohlstand commented 2 years ago

Just add them into sounds.ini, and internally, assign these new-added sounds with voice roles

vitzie629 commented 2 years ago

Just add them into sounds.ini, and internally, assign these new-added sounds with voice roles

Thank you! 😊

LoveBodhi commented 2 years ago

This is like NSMBWii & Hello Mario Engine!

P-Star7 commented 2 years ago

Players:

NPC's talking

Enemies' talking voices (when friendly)

Enemies' action voices

Note: To use the SMA2 sounds for Larry/Ludwig's deaths, the player simply assigns Larry/Ludwig's death sounds to use the same file

LoveBodhi commented 2 years ago

Another one: Message Box appeared (HME)

LoveBodhi commented 8 months ago

We shouldn't add pre-load SFX's anymore, as it affects load time. @Wohlstand @ds-sloth is it OK to close this?

ds-sloth commented 8 months ago

Yes, sounds good to close to me, thanks for the note.