search

TheXorog / BeatRecorder

Easily record your BeatSaber gameplay!
GNU General Public License v3.0
24 stars 0 forks source link

Placeholder filename ideas #12

Closed Fearce closed 2 years ago

Fearce commented 2 years ago

Hi, love this application. Had a few filename ideas:

TheXorog commented 2 years ago

I will most likely be able to implement the first two. The star difficulty is more difficult because DataPuller is quite unreliable when it comes to getting the BeatSaver (or ScoreSaber, not sure) info for each song. At least, when i did the initial implementation.

TheXorog commented 2 years ago

Oh and the other supported mod http-status doesn't give me any beatsaber/scoresaber info about the song at all.

TheXorog commented 2 years ago

I have to scrap bad cuts as well, sadly. Only Http-Status provides the info separately, unlike the other mods. Misses are supposed to include Bad Cuts, Missed Notes and Bombs Hit. I don't know why but sometimes some are simply not tracked when using DataPuller. I read that Beat Saber changed something on how it processes the current song state in some recent-ish update so i believe it has to something with that. Although this might've been fixed with the commit https://github.com/TheXorog/BeatRecorder/commit/4e95876aba7112ce941c3ce24cb89a8a0ce50c65.

To the last remaining placeholder: I simply made it so the <misses> Placeholder gets replaced with FC if you didn't miss: https://github.com/TheXorog/BeatRecorder/commit/b1666e2a952038c4b5f290dde484cd62a66a598c. Not a perfect solution, but the best i could come up with since again, not all mods provide the info required to properly check if it's a fc. (Not a perfect solution because if you enter a wall, it won't count as miss but break your combo)

TheXorog commented 2 years ago

The one thing that i was able to implement from this issue is now in 2.0. I'm sorry i couldn't implement them all.