search

TheZ3ro / apk2java-linux

Decompile apk and get java or smali source
84 stars 31 forks source link

Updates to the script #4

Closed MBtech closed 9 years ago

MBtech commented 9 years ago

Added features

  1. Removed the need to for sudo. The tool are downloaded into the script directory.
  2. User now has the option to specify the output directory for the decomipled output.
TheZ3ro commented 9 years ago

Great!

Just a little thing, what's the purpose of replacing #!/usr/bin/env python3 with #!/usr/bin/python3?

I think using env is much portable (It's a POSIX component thus found in pretty much every system), hard coding the python interpreter path is good on Debian systems (see debian python policy) but I think that the key point is don't get Error on users' system. (maybe users use virtualenv or python is installed in /usr/local/bin/.)

What do you think about? :smile:

MBtech commented 9 years ago

You are right, I guess. Though using #!/user/bin/env python3 was giving me weird problems on my ubuntu system. Apparently there is a problem in the env file that I had. It's messed up because of some other android stuff. Need to look into it.

TheZ3ro commented 9 years ago

It's ok, so you can make a new commit to fix that?

When it's ready I will merge the pull request :+1:

MBtech commented 9 years ago

Done :)

TheZ3ro commented 9 years ago

Thanks, merge done :)

MBtech commented 9 years ago

Perfect :D