search

TheZ3ro / apk2java-linux

Decompile apk and get java or smali source
84 stars 31 forks source link

Old version libraries #5

Open sytolk opened 8 years ago

sytolk commented 8 years ago

You can set version number of dex2jar apktool.. in .ini file

TheZ3ro commented 8 years ago

What about placing the INI file with version number in the tool's archive? The path will become something like "name_version.jar" and the ini will point which version use

sytolk commented 8 years ago

Its ok. Can you provide PR for this ?

sytolk commented 8 years ago

Why not INI fail to have download Url only and download libraries jar fails ?

sytolk commented 8 years ago

Its better to skip version in code "name.jar" download and rename fail without version. But use real Url for download not you repository

TheZ3ro commented 8 years ago

I've think about that, but download url are not fixed an can change for various reason (url goes offline, etc..) Other solutions?

sytolk commented 8 years ago

If this https://github.com/pxb1988/dex2jar is offline this download link will be offline too :) https://github.com/TheZ3ro/apk2java-linux/releases/download/tool/tool.zip dex2jar can be downloaded from two different repository sourceforge and bitbucket. Other solution is download URL in INI file to override hardcoded default URL in python code. But its need to have separated URLs for the each library. .INI file its need to be placing not in the tool's archive (its a part of the python code project). Its need to be placed in the python project dir. Like this project https://github.com/trickortweak/flickr-uploader

TheZ3ro commented 8 years ago

But what if pxb1988 change his nickname or change the repository owner? For my repository I can address this changes.

Anyway I think we can place the ini file in the project and if some tool isn't online report that to the users (and maybe automatically download a new updated ini file from this repository)

sytolk commented 8 years ago

If pxb1988 is changed link can be easy changed in .ini file if its have new version link can be changed too. The main idea is if I download master branch of this repository next year and view that its have outdated libraries I can change URLs in .INI and run decompiler with new one. Why not include tool libraries in project? if I checkout git repository python will download tool.zip -two download steps. Its better to have only one download source code with tools directory from github repository.

TheZ3ro commented 8 years ago

Uploading tool into the repository will increase the repository size.

I want a solution that always works even if I will stop maintaining this repo. Changing links will not work if I stop updating this project

sytolk commented 8 years ago

"Uploading tool into the repository will increase the repository size." -yes but I think that this is better instead of download it from releases. After you will stop maintainense.. I suppose that it will exist forks with changed .INI file only ;) and all forks will points to you repo. Thanks for this!

TheZ3ro commented 8 years ago

What about this:

Apk2java will read tool's urls from INI file. In the default INI file there will be the link to my repository tool's (always online). If user wan't update tool simply change the links in the INI file.

Remember: my goal is to have a tool that always works by default (cloning the repo in a clean PC). Different tools' version can behave differently (like #6 ) but that is up to the users. With the version I distribute on my repo, the project must always work.

:smiley:

sytolk commented 8 years ago

Its ok