search

TheZoraiz / ascii-image-converter

A cross-platform command-line tool to convert images into ascii art and print them on the console. Now supports braille art!
Apache License 2.0
2.05k stars 121 forks source link

Wired color #11

Closed PIndividual closed 2 years ago

PIndividual commented 2 years ago

When using the command "-C", image coloring looks wired.

Screen Shot 2021-09-10 at 8 14 53 AM
PIndividual commented 2 years ago

note that this is the original photo 47f71d4 (1)

TheZoraiz commented 2 years ago

From the file path in the terminal screenshot, I'm assuming you're using macOS. This is a common issue for terminals that don't support true colors. Try using iTerm2.

This also looks like a duplicate of issue #9. Perhaps I should include a message in the README or CLI help text.

TheZoraiz commented 2 years ago

8-bit coloring support has been added as of v1.10.0 (if 24-bit colors aren't supported by terminal) so you should be able to see colored ascii/braille art in your usual terminal from now on. Let me know if it works on your end.

PIndividual commented 2 years ago

cube-ascii-art

PIndividual commented 2 years ago

saving image works fine, but still looks wired if I run it in terminal

PIndividual commented 2 years ago

Screen Shot 2021-09-13 at 8 13 02 AM

PIndividual commented 2 years ago

does it mean that only an 8-bit image could be processed correctly in terminal?

TheZoraiz commented 2 years ago

That is strange. I tested it myself in the standard macOS terminal and it was working. Can you confirm that you're using v1.10.0 by executing ascii-image-converter -v? And what happens if you try coloring with a different terminal like iTerm2?

does it mean that only an 8-bit image could be processed correctly in terminal?

The 8-bit coloring I mentioned only refers to the terminal, so it doesn't depend on what image you're using.

PIndividual commented 2 years ago

Sorry, turns out that I failed to update ascii-image-converter from brew last time, now it works fine for me too, thanks for the help XD

Screen Shot 2021-09-13 at 6 48 11 PM
TheZoraiz commented 2 years ago

No worries, glad I could help!