TheZoroForce240 / FNF-Modcharting-Tools

Apache License 2.0
51 stars 23 forks source link

Psych engine 0.7.0 stuff and more #43

Closed EdwhakKB closed 1 year ago

EdwhakKB commented 1 year ago

I just fixed the 0.7 stuff and added some visual good stuff such as (eventModifier image instead of noteSkin for psych), added TweenManagers for stuff and same for times, also a lua documentation with added Modifiers lol have fun i guess

Rom4chek commented 1 year ago

C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartFuncs.hx:86: characters 23-31 : Class has no field instance C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartFuncs.hx:88: characters 23-31 : Class has no field instance C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartFuncs.hx:89: characters 23-31 : Class has no field instance C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartFuncs.hx:90: characters 23-31 : Class has no field instance C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartFuncs.hx:91: characters 23-31 : Class has no field instance C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartFuncs.hx:92: characters 23-31 : Class has no field instance C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartFuncs.hx:93: characters 23-31 : Class has no field instance C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartFuncs.hx:94: characters 23-31 : Class has no field instance C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:417: characters 113-122 : flixel.util.FlxAxes should be Float C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:417: characters 113-122 : ... For optional function argument 'ScrollX'

did u even tested ur thing?

Rom4chek commented 1 year ago

and not only that, there was still another organized folder stuff issues (conductor and clientprefs mostly)

EdwhakKB commented 1 year ago

C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartFuncs.hx:86: characters 23-31 : Class has no field instance C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartFuncs.hx:88: characters 23-31 : Class has no field instance C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartFuncs.hx:89: characters 23-31 : Class has no field instance C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartFuncs.hx:90: characters 23-31 : Class has no field instance C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartFuncs.hx:91: characters 23-31 : Class has no field instance C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartFuncs.hx:92: characters 23-31 : Class has no field instance C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartFuncs.hx:93: characters 23-31 : Class has no field instance C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartFuncs.hx:94: characters 23-31 : Class has no field instance C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:417: characters 113-122 : flixel.util.FlxAxes should be Float C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:417: characters 113-122 : ... For optional function argument 'ScrollX'

did u even tested ur thing?

sorry i forgot the funkin lua thing

the fix its just add this code inside funkin lua public static var instance:FunkinLua = null;

other stuff inside modchart thing its something you added and can you give the bugs for the Conductor and ClientPrefs stuff please?

Rom4chek commented 1 year ago

изображение_2023-07-27_123944718

uhh u gotta soon do fix for 0,7h

Rom4chek commented 1 year ago

C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartFuncs.hx:86: characters 23-31 : Class has no field instance C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartFuncs.hx:88: characters 23-31 : Class has no field instance C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartFuncs.hx:89: characters 23-31 : Class has no field instance C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartFuncs.hx:90: characters 23-31 : Class has no field instance C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartFuncs.hx:91: characters 23-31 : Class has no field instance C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartFuncs.hx:92: characters 23-31 : Class has no field instance C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartFuncs.hx:93: characters 23-31 : Class has no field instance C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartFuncs.hx:94: characters 23-31 : Class has no field instance C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:417: characters 113-122 : flixel.util.FlxAxes should be Float C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:417: characters 113-122 : ... For optional function argument 'ScrollX' did u even tested ur thing?

sorry i forgot the funkin lua thing

the fix its just add this code inside funkin lua public static var instance:FunkinLua = null;

other stuff inside modchart thing its something you added and can you give the bugs for the Conductor and ClientPrefs stuff please?

C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:104: characters 18-23 : Type not found : Paths C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:191: characters 16-25 : Type not found : Conductor C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:347: characters 3-12 : Type not found : Conductor C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:348: characters 3-12 : Type not found : Conductor C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:352: characters 60-65 : Type not found : Paths C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:390: characters 29-40 : Type not found : ClientPrefs C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:1006: characters 9-18 : Type not found : Conductor C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:1013: characters 50-55 : Type not found : Paths C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:1014: characters 53-58 : Type not found : Paths C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:1027: characters 44-49 : Type not found : Paths C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:1033: characters 13-22 : Type not found : Conductor C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:1107: characters 41-50 : Type not found : Conductor C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:1117: characters 72-81 : Type not found : Conductor C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:1165: characters 21-32 : Type not found : ClientPrefs C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:1194: characters 53-64 : Type not found : ClientPrefs C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:1195: characters 36-47 : Type not found : ClientPrefs C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:1207: characters 20-31 : Type not found : ClientPrefs C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:2105: characters 4-13 : Type not found : Conductor C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:526: characters 9-18 : Type not found : Conductor C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:529: characters 34-43 : Type not found : Conductor C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:536: characters 49-58 : Type not found : Conductor C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:561: characters 17-28 : Type not found : ClientPrefs C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:573: characters 13-24 : Type not found : ClientPrefs C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:612: characters 50-59 : Type not found : Conductor C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:631: characters 31-40 : Type not found : Conductor C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:640: characters 31-40 : Type not found : Conductor C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:678: characters 75-84 : Type not found : Conductor C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:693: characters 17-26 : Type not found : Conductor C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:710: characters 17-26 : Type not found : Conductor C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:770: characters 29-38 : Type not found : Conductor C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:772: characters 30-39 : Type not found : Conductor C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:823: characters 46-55 : Type not found : Conductor C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:828: characters 33-42 : Type not found : Conductor C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:842: characters 58-67 : Type not found : Conductor C:/HaxeToolkit/haxe/lib/fnf-modcharting-tools/git/source/modcharting/ModchartEditorState.hx:2274: characters 60-65 : Type not found : Paths

smth like this and not only in editorstate

EdwhakKB commented 1 year ago

weird, you are the only one that get that bug hmmm, i think i should see what breaks, for now continue with 0.6.3 while zoro or i fix that

Rom4chek commented 1 year ago

0.7.1 is out btw

Rom4chek commented 1 year ago

Thats why

EdwhakKB commented 1 year ago

OOOOH, okay i'll see whats wrong now then

Rom4chek commented 1 year ago

Basically i had issues with hscript, in modchart func there is hscript.variable.set stuff and it saying null reference

EdwhakKB commented 1 year ago

oh well, idk a lot of Hscript but i know someone who knows, we will fix that if zoro don't fix it for now

Rom4chek commented 1 year ago

Imagine if he will merge it lmao

Rom4chek commented 1 year ago

image

yo dude just saying only this makes game crash, i tested

Rom4chek commented 1 year ago

wait i just saw that i cant see sustains

EdwhakKB commented 1 year ago

sustains breaks? hmmm weird

Rom4chek commented 1 year ago

They became invisible, idk if its only me since i didnt touched sustains really deep but yeah, sustains moment

Rom4chek commented 1 year ago

In editor i cant see em too

EdwhakKB commented 1 year ago

weird, it don't happen to me hmmm

Rom4chek commented 1 year ago

Hmm well then i think i fucked up smth and its on note.hx thank god not playstate

Rom4chek commented 1 year ago

wait, no, my note.hx is almost same but it still makes sustains notes be invisible

EdwhakKB commented 1 year ago

is there any other bug that you get?

Rom4chek commented 1 year ago

Nope

EdwhakKB commented 1 year ago

okay, if there is any other bug then tell me on my discord instead lmao "@edwhak_kb"

Rom4chek commented 1 year ago

Alr