ThealeMW / slowaes

Slowaes
0 stars 0 forks source link

Minor syntax errors in cryptoHelpers.js (effects non-browsers) #12

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
In
http://slowaes.googlecode.com/svn/trunk/js/cryptoHelpers.js Revision 39.

There is a couple of minor syntax issues (found when running it through JSLint).

The issues don't occur when using it in browser, as the browser auto-fixes them 
for you.

But if you run it in a stricter environment (e.g. Windows Script Component), 
then it complains.

I've attached a patch file. 

btw. Awesome project guys, keep up the good work.

Original issue reported on code.google.com by alexander.key@gmail.com on 31 Mar 2011 at 9:27

Attachments:

GoogleCodeExporter commented 8 years ago
whoops, the last commit revision on that file was 35 (not 39) - I'm new to this 
:-)

Original comment by alexander.key@gmail.com on 31 Mar 2011 at 9:30

GoogleCodeExporter commented 8 years ago
I've found that the syntax errors actually cause parsing issues in IE8, and the 
interpreter will not properly load the script.

Original comment by bjanas...@gmail.com on 28 Feb 2012 at 3:26

GoogleCodeExporter commented 8 years ago
Interesting, it's been a little while since I last took a look at this, doesn't 
look like its active anymore as I haven't heard anything back. Perhaps we could 
fork the project and make a patch?

Original comment by alexander.key@gmail.com on 28 Feb 2012 at 7:21

GoogleCodeExporter commented 8 years ago
I've been quite uninvolved in the project, but I am interested in seeing it 
continue. I'd happily give you permissions on this project if you'd like to 
work on it here rather than forking the project.

Original comment by joshua.a...@gmail.com on 28 Feb 2012 at 7:33

GoogleCodeExporter commented 8 years ago
Sure that would be cool thanks. I'm no security pro (but I'm learning), but I 
can help out with some of the javascript stuff.

Must admit I'm a little stacked out with work at my day job at the moment 
(keeping busy busy busy), but I'll try to help out best I can.

Original comment by alexander.key@gmail.com on 29 Feb 2012 at 9:49