search

Theano / libgpuarray

Library to manipulate tensors on the GPU.
Other
189 stars 96 forks source link

Fix 581 (crash on 32bit) + spelling fixes #582

Closed rebecca-palmer closed 5 years ago

rebecca-palmer commented 5 years ago

cl_property uses a size_t to request some clGetDeviceInfo memory sizes that are actually cl_ulong (always 64 bit). On systems where size_t is 32 bit, this fails with CL_INVALID_VALUE (#581 reports this from ARM, but it can also happen on 32 bit x86).

This fix clips the values to fit in a size_t to avoid breaking ABI, but it might actually be better to switch to returning a cl_ulong.

The other commit is some spelling errors mostly found by Debian's lintian.

abergeron commented 5 years ago

I'm not sure how relevant the support for 32-bit is, but I agree with the fix, so ok.