Theblockbuster1 / disboard-auto-bump

Not against Discord's ToS!
MIT License
70 stars 16 forks source link

Bumps once then stops #16

Closed Evan933 closed 3 years ago

Evan933 commented 3 years ago

Hi, the autobumper was working great until it stopped for some reason. When I start the autobump it bumps once then opens a new tab to https://disboard.org/dashboard/servers and then the timer goes blank --:--:-- and doesn't autobump anymore. I tried reinstalling the plugin but it doesn't change anything.

PolishLithuanianCommonwealth commented 3 years ago

Found out, disboard issue, not the auto bump.

alexgurrola commented 3 years ago

This is almost certainly happening because of the target="_blank" on the bump link.

You can remove that from the tab by running the following code in your dev console:

document.getElementById('bumpme').removeAttribute('target')

I'm running that code in a tab right now to confirm it fixes the issue, so I'll check back here in a couple hours.

alexgurrola commented 3 years ago

The code above has now been tested and I can confirm that it does fix this issue. I will provide a couple more solutions another solution and wrap this up.

This code will remove all link targets on a page, so all links are unable to force a new tab to open:

Array.from(document.querySelectorAll('a[target]')).forEach(e => e.removeAttribute('target'))

This extension claims to do the same thing, without any hassle:

https://chrome.google.com/webstore/detail/death-to-blank/gneobebnilffgkejpfhlgkmpkipgbcno?hl=en

I'm running the Death To _blank extension in a tab right now to confirm it's an equivalent fix for this issue, so I'll circle back here in a couple hours.

Evan933 commented 3 years ago

thank you very much

On Wed, Jul 7, 2021 at 6:30 PM Alex Gurrola @.***> wrote:

The code above has now been tested and I can confirm that it does fix this issue. I will provide a couple more solutions and wrap this up.

This code will remove all link targets on a page, so all links are unable to force a new tab to open:

Array.from(document.querySelectorAll('a[target]')).forEach(e => e.removeAttribute('target'))

This extension claims to do the same thing, without any hassle:

https://chrome.google.com/webstore/detail/death-to-blank/gneobebnilffgkejpfhlgkmpkipgbcno?hl=en

I'm running the Death To _blank extension in a tab right now to confirm it's an equivalent fix for this issue, so I'll circle back here in a couple hours.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Theblockbuster1/disboard-auto-bump/issues/16#issuecomment-875977142, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHRUQYGP3U24ZUKTU2ZLSODTWTIQNANCNFSM47Z6U6UQ .

alexgurrola commented 3 years ago

@Evan933 no problem

alexgurrola commented 3 years ago

I tested the extension and it failed to work. The code I created for the console all work properly, though.

alexgurrola commented 3 years ago

@Theblockbuster1 Are you able to run the code in my snippet directly inside the extension?

Theblockbuster1 commented 3 years ago

Thanks for all of your contributions, I'm releasing a fix now :)