Theguyhere0 / villager-defense-minigame

A Minecraft plugin that adds a fun, customizable minigame where players defend villagers against waves of monsters
GNU General Public License v3.0
6 stars 4 forks source link

Power Heart duplication #128

Closed UBSMentis closed 1 year ago

UBSMentis commented 1 year ago

Describe the bug We have an Item that give 4 power Hearts to the player, before game join the player have 4 Hyellow Hearts, in game Villager Defence the Heart ar invisible, after the game, or quuit game the heart ar Duplucadet to 8 Hearts, you can repeat that over and over again and get more and more hearts to over 20 yellow Hearts. This Heart will only removed by a player Death

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior no hearts Duplication when playes leave ore Finish Villager Defence.

Screenshots If applicable, add screenshots to help explain your problem. 2022-12-05_00 36 23 2022-12-05_00 36 34 2022-12-05_00 36 42

Server and plugin versions (please complete the following information):

Additional context it would be good if the problem could be fixed , Greets from Germany

Theguyhere0 commented 1 year ago

Bug acknowledged, I'll go about fixing it once school is out of session. Thanks for the report!

UBSMentis commented 1 year ago

no problem nice job

UBSMentis commented 1 year ago

unfortunately the bug was not fixed with the new version. .1.2.5

Theguyhere0 commented 1 year ago

Understood, I wanted to get a release out quickly for 1.19.3 support. Still testing to see how I can fix this issue for the new version and the current version. I’ll push out 1.2.6 with some important bug fixes. Thanks for your patience!

On Tue, Jan 17, 2023 at 08:32 UBSMentis @.***> wrote:

unfortunately the bug was not fixed with the new version. .1.2.5

— Reply to this email directly, view it on GitHub https://github.com/Theguyhere0/villager-defense-minigame/issues/128#issuecomment-1385607918, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMQ5ZD3HW55DJPZJI6LQNPDWS23PZANCNFSM6AAAAAAS2S6KVY . You are receiving this because you commented.Message ID: @.***>

-- Max Lin

UBSMentis commented 1 year ago

THX for your good Support

Theguyhere0 commented 1 year ago

This seems like some sort of bug with how the absorption was added back after the game. I'll need to remove the "absorption heart saving" feature, so if you enter an arena, you lose your absorption hearts in survival.

UBSMentis commented 1 year ago

Hi thats sounds good and it is no Problem when the absobation hearts gone. Thx for your reply Greets from germany

Von meinem/meiner Galaxy gesendet

-------- Ursprüngliche Nachricht -------- Von: Theguyhere @.> Datum: 28.01.23 02:12 (GMT+01:00) An: Theguyhere0/villager-defense-minigame @.> Cc: UBSMentis @.>, Author @.> Betreff: Re: [Theguyhere0/villager-defense-minigame] Power Heart duplication (Issue #128)

This seems like some sort of bug with how the absorption was added back after the game. I'll need to remove the "absorption heart saving" feature, so if you enter an arena, you lose your absorption hearts in survival.

— Reply to this email directly, view it on GitHubhttps://github.com/Theguyhere0/villager-defense-minigame/issues/128#issuecomment-1407238463, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXM6XX3EH4QKPRJD42VUKY3WURXA5ANCNFSM6AAAAAAS2S6KVY. You are receiving this because you authored the thread.Message ID: @.***>

Theguyhere0 commented 1 year ago

Should be fixed in 1.2.6