search

Theguyhere0 / villager-defense-minigame

A Minecraft plugin that adds a fun, customizable minigame where players defend villagers against waves of monsters
GNU General Public License v3.0
7 stars 4 forks source link

[BUG] Phantom kit and late arrival break top wave records #162

Open UBSMentis opened 1 year ago

UBSMentis commented 1 year ago

Describe the bug Players who join in higher waves are directly on the leaderboard. When late Arraival is on, players can join in wave 60 and hes listet with wave 60 in the leaderboard, although they only played one wave. that would make the late Arraival joining and kit phantom pointless.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen. Leaderboard entry should be by waves played not by waves joined, example, a player joins in wave 30 and plays 4 waves up to 34, then this player should only be counted 4 played waves. Screenshots 247088417-82c55de9-4bf7-492b-862e-c75c2094f77e here you see Nuhbveerox played 5 waves, i joined in, in wave 5 and whe lost the game. i am allrady listet with 5 waves in the Leaderboard although I only played one wave.

Server and plugin versions (please complete the following information):

Additional context Add any other context about the problem here.

Theguyhere0 commented 1 year ago

Oh huh, that's something I don't think I considered, I'll find a solution to that. Thanks for bringing this up!

UBSMentis commented 1 year ago

i think with player feedbacks youre VD will be even better ;)

Theguyhere0 commented 1 year ago

I'm going to leave it as is for now in v1, but I'll implement logic to check against this in v2. Really don't want to spend too much more time in v1 if I can help it. Leaving this issue open for now until a production version of v2 comes out that fixes this