1.20.2/4 support - Githubissues

Theguyhere0 / villager-defense-minigame

A Minecraft plugin that adds a fun, customizable minigame where players defend villagers against waves of monsters

GNU General Public License v3.0

7 stars 4 forks source link

1.20.2/4 support #179

Closed datatags closed 8 months ago

datatags commented 11 months ago

This PR adds 1.20.2 support. I did some brief testing and things seem to work, specifically the "join a game" villagers and the holograms. I didn't bump the version though, not sure how you handle that.

By the way, are there any plans to switch to Mojang mappings? It really does make it significantly easier to work with NMS. Thanks!

Theguyhere0 commented 10 months ago

Hey, thanks for the PR! I'm busy with school right now, but I'll probably get to this during Thanksgiving break. I can handle the versioning. Eventually, I'll clean up the documentation so that people can contribute to this project more easily and help maintain it 😅

Regarding Mojang mappings, I have actually switched in V2 which I've been working on. I don't plan on doing any more work in V1, besides support updates until V2 reaches production.

datatags commented 8 months ago

PR updated with 1.20.4 support :grin:

Theguyhere0 commented 8 months ago

Thank you so much for your help here. It's been a little bit since I've worked on this, but I should be able to put in more time on this project. Cheers!