Describe the bug
Achievements that require the player to get "past at least wave X" with specific challenge(s) (e.g. "It Hurts So Good") can be instantly unlocked by leaving during the "game starting" phase.
To Reproduce
Steps to reproduce the behavior:
Ensure you don't have all challenge-wave achievements unlocked already
Join a VD arena
Before the countdown finishes, equip all challenges and then leave the game.
Observe you now have all challenge-wave achievements unlocked.
Expected behavior
No achievements should be unlocked since the game never actually started.
Screenshots
Server and plugin versions (please complete the following information):
OS: Debian 11
Server type (including the version): This server is running Paper version git-Paper-401 (MC: 1.20.4) (Implementing API version 1.20.4-R0.1-SNAPSHOT) (Git: 1ed50da)
Villager Defense version: 1.2.9 with 1.20.2/4 support
Additional context
Seems to be caused by these lines missing a check for ArenaStatus.WAITING
Describe the bug Achievements that require the player to get "past at least wave X" with specific challenge(s) (e.g. "It Hurts So Good") can be instantly unlocked by leaving during the "game starting" phase.
To Reproduce Steps to reproduce the behavior:
Expected behavior No achievements should be unlocked since the game never actually started.
Screenshots
Server and plugin versions (please complete the following information):
Additional context Seems to be caused by these lines missing a check for
ArenaStatus.WAITING