Thelnfamous1 / Mob-Player-Animator

An add-on mod to Player Animator that allows it to work with humanoid mobs.
Creative Commons Zero v1.0 Universal
1 stars 2 forks source link

newest update causes vindicator to be armless after FA fix #5

Closed YnwLNE closed 3 weeks ago

YnwLNE commented 1 month ago

Applying the update and following the directions (removing vindicator from the "emf_force_vanilla_models") does fix the facial animations but ends up breaking the arms by making them disappear during swings

image huge_2024-07-11_09 18 10

YnwLNE commented 1 month ago

Tested with different versions of FA, the latest fixes the arms but the axe still randomly disappears for a split second.

Guard Villagers are broken if you're using the FA addon https://modrinth.com/resourcepack/freshly-modded (latest version) but that's to be expected as that's not officially supported.

Feel free to close this commit.

In other words, this mod has quickly become one of my favorite mods to include life and immersion into a mostly static game, thank you for you work!

Thelnfamous1 commented 1 month ago

I was testing with the latest version of Fresh Animations for 1.20.1, which is 1.9.2, so that's what the Vindicator model modifier in the config was made for.

I noticed the brief disappearance of the weapon, that is likely due to the vanilla AI for the Vindicator. I will look into a fix for it.

Guard Villagers are completely fine if you use Fresh Friends, that's what I tested with. You can move Fresh Friends higher in the Resource Pack hierarchy and it will override the Freshly Modded model for them.

If you prefer the Freshly Modded model, you will need to make an entry in the emf_model_modifiers config for Guard Villagers that makes the necessary adjustments.

Thelnfamous1 commented 1 month ago

I'll keep this open until I fix the weapon disappearance bug for Vindicators.

YnwLNE commented 1 month ago

I was testing with the latest version of Fresh Animations for 1.20.1, which is 1.9.2, so that's what the Vindicator model modifier in the config was made for.

I noticed the brief disappearance of the weapon, that is likely due to the vanilla AI for the Vindicator. I will look into a fix for it.

Guard Villagers are completely fine if you use Fresh Friends, that's what I tested with. You can move Fresh Friends higher in the Resource Pack hierarchy and it will override the Freshly Modded model for them. If you prefer the Fresh Friends model, you will need to make an entry in the emf_model_modifiers config for Guard Villagers that makes the necessary adjustments.

Haven't heard of Fresh Friends but I'll look into adding it to the emf_model_modifiers and possibly the one from Freshly Modded as well since it doesn't like being stacked with FF, thank you for the guidance!

Thelnfamous1 commented 1 month ago

I made an error in my sentence about adding the Guard Villager to the config. I meant to say if you prefer the Freshly Modded model, then you will need to make an emf_model_modifiersentry for Guard Villagers. The Fresh Friends model needs no adjustments.

YnwLNE commented 1 month ago

Dw, I caught onto that! Partially got it working and now just needs tinkering with the part_modifiers.

Thelnfamous1 commented 3 weeks ago

I'll keep this open until I fix the weapon disappearance bug for Vindicators.

This will be fixed in Better Mob Combat 1.2.0, as the fix was more suitable to be implemented there.