Themapworkshop / COVID19TRACKER

QGIS Plugin to track the spread of COVID19
0 stars 1 forks source link

Plugin approval #1

Open NyakudyaA opened 4 years ago

NyakudyaA commented 4 years ago

Problem Just tried to install this plugin and got the following error.

  import pandas as pd
              File "/gis/compiled_programs/QGIS_3_10_3/build_master/output/python/qgis/utils.py", line 744, in _import
              mod = _builtin_import(name, globals, locals, fromlist, level)
             ModuleNotFoundError: No module named 'pandas'

Please update the metadata or readme to include a list of dependencies

Themapworkshop commented 4 years ago

Hi The pandas module should be included in QGIS3.10 by default. The plugin was developed on QGIS3.10.

I will have a look at it, and update the list of dependencies as soon as possible :)

Kind regards Pawel

Den man. 16. mar. 2020 kl. 17.29 skrev mazano notifications@github.com:

Problem Just tried to install this plugin and got the following error.

import pandas as pd File "/gis/compiled_programs/QGIS_3_10_3/build_master/output/python/qgis/utils.py", line 744, in _import mod = _builtin_import(name, globals, locals, fromlist, level) ModuleNotFoundError: No module named 'pandas'

Please update the metadata or readme to include a list of dependencies

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Themapworkshop/COVID19TRACKER/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOGWVOIBFRDR4FRXPMTZRIDRHZHW7ANCNFSM4LMNE6AQ .

Themapworkshop commented 4 years ago

Hi I had now added the changes on Readme.txt on Github. The plugin needs these python modules to be installed to work:

pandas requests, numpy, os However it should work on QGIS3.10, since they are installed allready in the python environment. Kind regards Pawel

Den man. 16. mar. 2020 kl. 17.38 skrev TheMap Workshop < themapworkshop@gmail.com>:

Hi The pandas module should be included in QGIS3.10 by default. The plugin was developed on QGIS3.10.

I will have a look at it, and update the list of dependencies as soon as possible :)

Kind regards Pawel

Den man. 16. mar. 2020 kl. 17.29 skrev mazano notifications@github.com:

Problem Just tried to install this plugin and got the following error.

import pandas as pd File "/gis/compiled_programs/QGIS_3_10_3/build_master/output/python/qgis/utils.py", line 744, in _import mod = _builtin_import(name, globals, locals, fromlist, level) ModuleNotFoundError: No module named 'pandas'

Please update the metadata or readme to include a list of dependencies

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Themapworkshop/COVID19TRACKER/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOGWVOIBFRDR4FRXPMTZRIDRHZHW7ANCNFSM4LMNE6AQ .

Gustry commented 4 years ago

Hi I had now added the changes on Readme.txt on Github.

You should remove readme.html because https://github.com/Themapworkshop/COVID19TRACKER is not readable.

You should add them to the metadata.txt, this is the most important file for a QGIS plugin.

Your metadata.txt still mentions valid for QGIS 3.0: https://github.com/Themapworkshop/COVID19TRACKER/blob/master/metadata.txt#L7

The plugin needs these python modules to be installed to work: pandas requests, numpy, os However it should work on QGIS3.10, since they are installed allready in the python environment.

This depends how you install QGIS. I'm running QGIS 3.13, but I don't have panda.

Themapworkshop commented 4 years ago

Hi I had now removed readme.html and added the dependencies to metadata.txt.

Regarding the QGIS 3.0, that's the minimum version it can be run on, I just haven't yet had the opportunity to test in QGIS3.0 or 3.2. I had however successfully tested it on QGIS3.4 and it also works fine. I have now updated Readme.txt and metadata.txt

Kind regards Pawel

Den tor. 19. mar. 2020 kl. 14.39 skrev Étienne Trimaille < notifications@github.com>:

Hi I had now added the changes on Readme.txt on Github.

You should remove readme.html because https://github.com/Themapworkshop/COVID19TRACKER is not readable.

You should add them to the metadata.txt, this is the most important file for a QGIS plugin.

Your metadata.txt still mentions valid for QGIS 3.0:

https://github.com/Themapworkshop/COVID19TRACKER/blob/master/metadata.txt#L7

The plugin needs these python modules to be installed to work: pandas requests, numpy, os However it should work on QGIS3.10, since they are installed allready in the python environment.

This depends how you install QGIS. I'm running QGIS 3.13, but I don't have panda.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Themapworkshop/COVID19TRACKER/issues/1#issuecomment-601183436, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOGWVOMAUTUR3AE2EK6O5ADRIIN77ANCNFSM4LMNE6AQ .

pcav commented 4 years ago

Should this be closed then?