search

ThematicTheme / Thematic

Thematic is a free, open-source, highly extensible, search-engine optimized WordPress Theme Framework featuring 13 widget-ready areas, grid-based layout samples, styling for popular plugins, and a whole community behind it. It's perfect for beginner bloggers and WordPress development professionals. Download it today and set your WordPress-powered site on a rock-solid foundation.
http://thematictheme.com
92 stars 42 forks source link

Remove postheader_posttitle "Permalink to" text from .entry-title #102

Closed scottnix closed 10 years ago

scottnix commented 10 years ago

Currently on the thematic_postheader_posttitle there is a title added which appends the text "Permalink to . This drives the SEO in me crazy, but recently I haven't been a fan of adding the title at all since it generates exactly the same as it will render in plain text, which makes it unneeded. The title (when hovered over) will also produce a tooltip with the same text.

Maybe I am missing a use case in where this would be beneficial, but currently the Twenty Thirteen & Fourteen themes also do not apply titles.

While it would be nice to drop the title attribute completely, at least removing the "Permalink to" from it would be nice. :)

middlesister commented 10 years ago

I did a little research and it seems the practice of the title attributes just followed along from a long time ago and has no clear benefit. https://core.trac.wordpress.org/ticket/24203

I think we can safely remove the title attribute completely.

scottnix commented 10 years ago

I will double check Thematic, I think there is one more section that uses "Permalink to" which may fall into the same category of legacy stuff done for no purpose. :P

middlesister commented 10 years ago

I found two more places. There are permalink title attributes on featured thumbnails and on custom post type archive links. Are these also candidates for removal? Although the title in this case differ from the content of the link?

ghost commented 10 years ago

looking at 2.0 as a last chance for making major changes in output i say Scotts got a point with abandoning the old practice

middlesister commented 10 years ago

I've removed a bunch of title attributes throughout. The use - or rather reliance on it - is generally discouraged in html5 since it excludes keyboard-only users as well as touch-only users. It's basically useless for tablets and mobile. References http://mrwweb.com/the-title-attribute-and-why-its-almost-useless/ http://www.paciellogroup.com/blog/2013/01/using-the-html-title-attribute-updated/

This is a good start in an accessibility effort. I'd like the next release to get Thematic as far as possible in this regard and earn the accessibility-ready tag in the theme repo.

This also removes some strings for translation. It's not a huge deal. I will regenerate a pot file before release but having unused strings in the translation files is much less serious than having strings untranslated.