search

ThematicTheme / Thematic

Thematic is a free, open-source, highly extensible, search-engine optimized WordPress Theme Framework featuring 13 widget-ready areas, grid-based layout samples, styling for popular plugins, and a whole community behind it. It's perfect for beginner bloggers and WordPress development professionals. Download it today and set your WordPress-powered site on a rock-solid foundation.
http://thematictheme.com
92 stars 42 forks source link

legacy mode breaks any page tempates in the child theme (they never load... #109

Closed helgatheviking closed 10 years ago

helgatheviking commented 10 years ago

.../are redirected to use the legacy-page.php)

To continue our twitter convo: I would agree that I don't like the checkbox for legacy mode... and I definitely didn't like that it was automatically on, but maybe that's b/c it just drove me crazy for the last 3 hours.

I prefer add_theme_support() even if that is maybe a touch harder for total non-coders.

middlesister commented 10 years ago

Thanks!

The idea is this:

Previous install gets upgraded == stays xhtml in legacy mode by default Previous install transitions == uses add_theme_support( thematic-html5 ) to switch the markup New installs == automatically gets html5 markup without doing anything specific

I'll have to look a bit further for the new installs scenario. I think Genesis requires the theme_support call for any theme that want html5 markup. It's possible that will be necessary, but trivial to add to the sample child theme and put into documentation.

helgatheviking commented 10 years ago

Seems like a good plan to me. Just a small catch then on this issue. And something to think about with the theme option.