search

ThemeFuse / Unyson

A WordPress framework that facilitates the development of WP themes
http://unyson.io
922 stars 217 forks source link

Unyson Extensions Can't be deployed in Pantheon TEST/LIVE env due to .gitignore #3615

Open carl-alberto opened 6 years ago

carl-alberto commented 6 years ago

The .gitignore file that ignores the whole extension folder for Unyson additional extensions which is located in - wp-content/plugins/unyson/framework/extensions/shortcodes/.gitignore blocks the plugins' additional extension to be deployed in TEST and LIVE.

Would it be possible that .gitignore file is removed from the public repo?

iajay commented 6 years ago

Nice find.. I deleted the .gitignore from the dev site, committed to dev and then deployed to test and the plugins are working

carl-alberto commented 6 years ago

Upon further digging, it seems the internal Unyson Extensions are not consistently installed on a standard extension path.

Some of the Unyson Extensions that adds a .gitignore file when installed and might potentially exclude the code to be deployed in TEST and LIVE environments

Page builder wp-content/plugins/framework/extensions/shortcodes/.gitignore wp-content/plugins/framework/extensions/shortcodes/extensions/page-builder/.gitignore

WordPress Shortcodes wp-content/plugins/unyson/framework/extensions/shortcodes/.gitignore

Translate Press wp-content/plugins/unyson/framework/extensions/shortcodes/.gitignore

Events wp-content/plugins/unyson/framework/extensions/events/.gitignore

Brizy wp-content/plugins/brizy/vendor/twig/twig/.gitignore

Deleting these .gitignore files will let you deploy to TEST and LIVE environments but still can potentially be messed up if not removed by the plugin author on its next plugin releases.

Unable to deploy code properly affects the user experience and causes frustration in using the plugin after they invest time developing, then later on, finding out that it won't work because they are unable to deploy the changes they made.

iajay commented 6 years ago

Totally Agreed

justinkames commented 6 years ago

I had a problem with extensions being disabled on LE environment every time I redeployed ( deployment is done by git push ). I couldn't figure out why. Removing the shortecodes/.gitignore file specified by @carl-alberto fixed this. I guess this might be linked to other issues where extensions uninstalling / disable automatically.

Thanks!

carl-alberto commented 6 years ago

Thanks for the confirmation of the workaround @justinkames