ThemeFuse / Unyson

A WordPress framework that facilitates the development of WP themes
http://unyson.io
922 stars 218 forks source link

Allow GiveWP CSS to be enqueued #3624

Closed kevinwhoffman closed 5 years ago

kevinwhoffman commented 6 years ago

Hi, I'm a developer from GiveWP. We recently had a customer report an issue where GiveWP admin styles were not loading when used alongside your Philanthropy theme.

I then discovered an old issue from 2016 that explained why you might have dequeued our styles because of a CSS conflict. https://github.com/impress-org/give/issues/466

Our CSS has evolved over the last two years and we kindly ask that you allow our admin styles to be enqueued alongside your theme for the benefit of our mutual customers.

Here is the code in question that we are asking to be removed so that our admin styles are restored:

philanthropy-parent\theme-includes\hooks.php at line 6874:

if ( ! function_exists( 'the_core_give_load_admin_styles' ) ) :
    function the_core_give_load_admin_styles() {
        return false;
    }
endif;
add_filter( 'give_load_admin_styles', 'the_core_give_load_admin_styles' );

Thank you for considering this fix.

andronic90 commented 6 years ago

Hi,

we make an update to this some time ago.

We included your styles only for post_type "give_forms" because you load the styles in all admin and broke some of our builder styles.

mathetos commented 6 years ago

@andronic90 Please read Kevin's issue again, there's been changes since your previous workaround. Your function now breaks our form pages completely when Philanthropy and Give are both active.

andronic90 commented 6 years ago

@mathetos - i see that the code that give your colleague is not our final code.

Now is something like this:

$return = false;
$post_type = get_post_type();
if ( function_exists('give_is_admin_page') && give_is_admin_page() ) {
    if ( 'give_forms' == $post_type ) {
        $return = true;
    }
}

return $return;

Have this client the latest theme version?

If the client have the latest version and the problem persist please let contact us to: support@themefuse.com and I will help with this.

ViorelEremia commented 5 years ago

Please contact the theme author support@themefuse.com