ThemeFuse / Unyson

A WordPress framework that facilitates the development of WP themes
http://unyson.io
924 stars 218 forks source link

Unyson php 7.4 to 8.0 PHP Deprecated #4253

Open josipWebbite opened 2 years ago

josipWebbite commented 2 years ago

Hi, since PHP 7.4 will be obsolete in few months I started to move all clients sites to PHP 8.0.

I am getting at debug.log PHP Deprecated: Required parameter $zip_path follows optional parameter $full in /hidden_path/public_html/wp-content/plugins/unyson/framework/extensions/backups/includes/module/tasks/class--fw-ext-backups-module-tasks.php on line 985

As I understand this:

public function do_restore($full = false, $zip_path, $filesystem_args = array()) {

$zip_path should be first, like this:

public function do_restore( $zip_path, $full = false,$filesystem_args = array()) {

I runing newest Unyson version 2.7.27

yarlevi commented 1 year ago

have the same issue, is that resolved somehow? running Unyson 2.7.28

josipWebbite commented 1 year ago

Fix is here https://github.com/ThemeFuse/Unyson/issues/4231