search

TheoChevalier / typolib

Home of the Typolib’ project
http://typolib.theochevalier.fr
0 stars 6 forks source link

Rename $success and $errors arrays #122

Closed TheoChevalier closed 9 years ago

TheoChevalier commented 9 years ago

We're using those arrays to display messages to the user, but the name of the variable is too generic and we are overwriting the variable in many places.

We should be using $success_msg and $error_msg instead.

TheoChevalier commented 9 years ago

To be more explicit, doing that here: https://github.com/TheoChevalier/typolib/blob/master/app/models/inserted.php#L11

Is making code fail here https://github.com/TheoChevalier/typolib/blob/master/app/views/templates/base.php#L49

TheoChevalier commented 9 years ago

https://github.com/TheoChevalier/typolib/blob/master/app/models/inserted.php#L17 -> We should either use Monolog or $error_msg[] is we need to display in on the page. Then we can remove this view https://github.com/TheoChevalier/typolib/blob/master/app/views/inserted.php