search

TheoKouzelis / laravel-airbrake

Laravel service provider for Airbrake https://github.com/airbrake/phpbrake
MIT License
25 stars 24 forks source link

Update `keysBlacklist` option to `keysBlocklist` #16

Open thompiler opened 3 years ago

thompiler commented 3 years ago

Howdy!

We recently updated the phpbrake library to use updated terminology for the filtering option. keysBlacklist is still supported but is deprecated in favor of keysBlocklist. Users that set keysBlacklist will see a message like this in their log though it will still work at filtering params:

phpbrake: keysBlacklist is a deprecated option. Use keysBlocklist instead.

I've done some testing myself (full disclosure: Laravel novice) with this library in an example Laravel app and I think simply updating these two mentions to keysBlocklist would do the trick:

https://github.com/TheoKouzelis/laravel-airbrake/blob/e6adcae6c9577224a59f8a635602b4de12e04143/config/airbrake.php#L15

https://github.com/TheoKouzelis/laravel-airbrake/blob/da1e9470efd43ccdb82c025143d7ffd9662bfd28/README.md#L40

I'd be happy to submit a PR for that if you think that would be helpful.

TheoKouzelis commented 3 years ago

Hi @thompiler

Thanks for the heads up. I will get that change done tonight.

TheoKouzelis commented 2 years ago

Hi @thompiler Yes please if you could create a PR that would be great