search

Thertzlor / semantic-rainbow

A maximalist VSCode color theme for semantic highlighting featuring bold colors and subtle distinctions.
https://thertzlor.github.io/semantic-rainbow/
GNU General Public License v3.0
15 stars 4 forks source link

Diff comments hard to read #2

Closed pikeas closed 1 year ago

pikeas commented 1 year ago

Describe the bug In the source code diff view, it's difficult to read comments on newly added lines, and new comments added to existing lines.

To Reproduce Add a comment and open the diff view.

Expected behavior Newly added comments should be legible in diff view.

Screenshots

Screen Shot 2022-10-18 at 1 05 05 PM
Thertzlor commented 1 year ago

Definitely going to include a fix for this in the next release. I'll leave the color of the comments themselves alone, but a good way to increase the contrast seemed to be turn down the brightness of the diff background, and then slightly increasing the saturation to regain noticeability with less impact on legibility: image

Thertzlor commented 1 year ago

Closing as the brighter comment color has been included in the last update.