Theseus-Aegis / Mods

Collection of systems, tweaks and enhancements for Arma 3
https://www.theseus-aegis.com
Other
19 stars 8 forks source link

Mission - Handle errors in Mortar Strike #634

Closed Mike-MF closed 1 year ago

Mike-MF commented 1 year ago

When merged this pull request will:

1 2

jonpas commented 1 year ago

Look at those errors out of context, and tell me if you'd know what they are about at all? They need to tell the user "I am this script, this is why I am not working".

Mike-MF commented 1 year ago

Not outside of it, I test the missions now so I'd only need to see this during review really

jonpas commented 1 year ago

You do now, maybe you won't in the future.

Does the function still "work" (does not error otherwise) if any of those "errors" remain?

Mike-MF commented 1 year ago

Two are hard failures, CBA Setting & Barrages at 0, can't fire with it. Out of range can still work if you give it multiple targets and at least 1 is within range, but not with the exitWith

jonpas commented 1 year ago

Two are hard failures, CBA Setting & Barrages at 0, can't fire with it.

So function should not run in that case at all, to prevent any script errors or missing functionalities.