Lowers the complexity of the function, removes the barrages part entirely.
Still handles MK6 Mortar & D30 as before.
random amount is now whole number.
Handles invalid markers with error. (has to be done before inRange otherwise that will be the error, easier to debug this way.)
Instead of firing an amount every X barrage, now just fires 1 round until it reaches required amount.
Returns the ETA of the round and the amount fired.
Now uses the correct syntax for doArtilleryFire
I'm being nice and even writing out a reason for this one before I forget.
Something was off with amount & barrages, not entirely sure what but you wouldn't get the amount fired you wanted. Plus it just added to the confusion of this entire function.
I had a usecase for the ETA and amount fired which it didn't provide.
Overall, it's simpler now at the cost of broken BWC which is just 1 parameter.
When merged this pull request will:
doArtilleryFireI'm being nice and even writing out a reason for this one before I forget. Something was off with amount & barrages, not entirely sure what but you wouldn't get the amount fired you wanted. Plus it just added to the confusion of this entire function. I had a usecase for the ETA and amount fired which it didn't provide. Overall, it's simpler now at the cost of broken BWC which is just 1 parameter.
It works!