Thesola10 / osu-DIVA

Archived development fork of osu!DIVA
MIT License
4 stars 0 forks source link

Do we need to rewrite everything from scratch...? #25

Closed Thesola10 closed 3 years ago

Thesola10 commented 3 years ago

Ever since I wrote #17 and had a good look at osu!classic's code, I've been wondering if we aren't barking up the wrong tree, and need to revisit the entire architecture before it's too late.

For instance, timing code on osu!DIVA being in DrawableDivaHitObject.cs (note the Drawable) is part of the reason for #10, or certainly didn't make it easier to fix.

Far from the idea of speaking ill of @Artemis-chan's work -- quite the opposite, without your project I wouldn't even dare start work on an osu! ruleset...

My proposal is to fork the code from osu!classic, then build osu!DIVA features on top, given that osu!classic is the closest in feature set to this project. This will allow us to inherit a known-working architecture and build on the shoulders of giants.

This would also make it easier to backport code from other stock osu! rulesets, like Mania, for our conversion decision algorithm, or our editor.