Closed AnthonyAkentiev closed 6 years ago
mapping (uint=>bytes32) params
if(VotingType.VotingSimpleToken==vp.votingType){
return new Voting_SimpleToken(dao, _proposal, _origin,
uint(vp.param1),
uint(vp.param3),
uint(vp.param4),
address(vp.param5),
false);
}
=>
return new Voting_SimpleToken(dao, _proposal, _origin, this);
Custom types for parameters. Remove converts.
mapping (ID=>uint) mUint;
mapping (ID=>bool) mBool;
...
Move generic code/vars to Voting()
Create single Voting contract
Branch is here - dev2-memory-fix
Take it and run tests. What i did - https://github.com/Thetta/Thetta-DAO-Framework/commit/14be1615d5e44d861d7148c802022c2b499bdc7f
I just added additional voting to the GenericCaller: