ThexXTURBOXx / BlockHelper

Basically WAILA for b1.2_02-1.5.2
https://modrinth.com/mod/block-helper
MIT License
8 stars 3 forks source link

Legacy Fabric support [needs work in other mod] #8

Closed thecatcore closed 2 years ago

ThexXTURBOXx commented 2 years ago

Block Helper is built on top of ModLoaderMP and Minecraft Forge and, thus, support for Fabric won't be as easy as you might think. Because of this, Fabric will remain unsupported until mods like BetaLoader are available for the respective Fabric versions. I am sorry!

thecatcore commented 2 years ago

I've made a mod similar to BetaLoader for 1.3.2 ModLoader. I'm only focusing on ModLoader rn, but I'll try doing the same with Forge later.

ThexXTURBOXx commented 2 years ago

I see! Good job on what you've got so far! :) However, Block Helper needs Forge on 1.3.2, so I cannot test it until basic Forge support has been added. As soon as you've added basic Forge support, I can help you fix bugs and so on until Block Helper works. Then, you are of course also free to support additional Minecraft versions also and I will be happy to add support for your mod inside Block Helper.

thecatcore commented 2 years ago

Hm I guess we can close this issue now :smile: image

ThexXTURBOXx commented 2 years ago

I was actively watching your progress on that mod. Congratulations :) I will thoroughly test mod compatibility soon-ish and potentially fix BlockHelper accordingly, though!

thecatcore commented 2 years ago

Maybe disable the warnings for ClassLoaderFixer and FontFixer when FabricLoader is detected? My forge compatibility layer doesn't support Jar Mods and it seems difficult to implement them. I can implement the fixes as mixins as fabric mods if you still want the fix to be applied?

ThexXTURBOXx commented 2 years ago

I already implemented the FontFixer as a Mixin mod in b1.7.3 :) So, it will be very easy for me to port it to 1.3.2. So no worries there, I will handle that! I am unsure if the ClassLoaderFixer is even required. This is something that will get tested simultaneously when testing mod compatibility. So, also no worries about that for now! :)

thecatcore commented 2 years ago

Awesome :+1: