search

ThexXTURBOXx / dex2jar

Tools to work with android .dex and java .class files
Apache License 2.0
229 stars 57 forks source link

Method code too large exception #24

Closed ZXTube closed 2 years ago

ZXTube commented 2 years ago

Please fix the Method code too large exception.

In this Issue comment (Which is in the main dex2jar repository) the comment explained that this exception is not necessary at all and then explained how to edit the byte code so that this exception doesn't happen anymore.

Please make it so that this exception doesn't happen by default.

Thank you.

ThexXTURBOXx commented 2 years ago

I don't like fiddling around bytecode editing some jars we depend on since any version update will immediately break this. However, maybe I am able to work around it differently by overwriting this function myself. I have not looked at the source code yet since I am very busy (and it is very late right now here). But maybe I am able to play with this a bit in the next few days. Also, another big problem I have with this approach: dex2jar also provides "recompiling" functionality and some users may complain afterwards anyway. But well... It's anyways better to support at least one-way conversion than no-way conversion :)

ThexXTURBOXx commented 2 years ago

I applied a similar workaround to the one in the linked comment in v53. Please see if it works for you, thanks!

ZXTube commented 2 years ago

Yes! Thank you it works now. Also thanks for answering quickly