Add ASWebAuthenticationSession.Callback support

ThexXTURBOXx / flutter_web_auth_2

Flutter plugin for authenticating a user with a web service

https://pub.dev/packages/flutter_web_auth_2

MIT License

53 stars 54 forks source link

Add ASWebAuthenticationSession.Callback support #104

Closed kay-schecker closed 3 months ago

kay-schecker commented 7 months ago

Is your feature request related to a problem? Please describe.

If I wanna use the https scheme and Universal Links on iOS the completionHandler is not called.

This is related to Issue #65

Describe the solution you'd like

Apple has deprecated the previous initializer matching in favor of the new initializer factory functions:

ASWebAuthenticationSession.Callback.customScheme(String)
ASWebAuthenticationSession.Callback.https(host: String, path: String)

ThexXTURBOXx commented 6 months ago

Sadly, my MacOS VM is not working properly anymore, so I cannot work on this issue without blindly replacing things. If you have access to Apple hardware (or a VM), feel free to contribute via PR! :)

ThexXTURBOXx commented 5 months ago

I finally had access to a Macbook of a friend of mine. At least I was able to add partial support for the new initializer. I tested it on a simulator for iOS and the macBook itself - both worked fine. However, I don't know if this breaks older environments, so it is good to have this published within the 4.x alpha cycle. For now, I have not added ASWebAuthenticationSession.Callback.https(host: String, path: String), but I may do that at some other point. Hence, I will keep this issue open for now.

wildsurfer commented 3 months ago

@ThexXTURBOXx +1 for this feature

ThexXTURBOXx commented 3 months ago

@wildsurfer Feel free to create a PR :)