ThexXTURBOXx / flutter_web_auth_2

Flutter plugin for authenticating a user with a web service
https://pub.dev/packages/flutter_web_auth_2
MIT License
57 stars 55 forks source link

[Bug]: <Choose an appropriate title> #119

Closed reidbaker closed 3 months ago

reidbaker commented 3 months ago

Description

Remove references to deprecated v1 Android embedding

To ensure this plugin will work with users running the next stable version of Flutter remove references to the v1 embedding.

The v1 embedding was deprecated around 6 and a half years ago. In Flutter 3.22, the Flutter tool dropped support for building v1 apps entirely. Flutter plans to delete version one of it's Android embedding in the next stable release, per https://medium.com/flutter/whats-new-in-flutter-3-22-fbde6c164fe3 (in the "Removal of v1 Android embedding" section).

When that deletion happens, any apps using plugins that still have references to the removed classes will fail to build when updating to the next stable version (probably Flutter 3.26).

As a part of this deprecation, the Flutter Android team is doing community outreach by filing bugs and submitting some pull requests to update plugins to minimize the impact this removal has on the community.

Some example PRs:

Consequences:

If this change doesn't land, this plugin will instead be broken for all apps building on the next stable version of Flutter and beyond.

Is there a way to support both v1 and v2 embedding apps in the next stable version of Flutter?

No.

This is the PR where we are removing the deprecated engine classes: https://github.com/flutter/engine/pull/52022

Minimal Reproduction

Any flutter app built using this plugin and engine pull request https://github.com/flutter/engine/pull/52022

Exception or Error

compilation error, missing classes

Expected Behaviour

compile

Screenshots

n/a

Additional context

n/a

Device

all

OS

android

Browser

n/a

Flutter version

future

flutter_web_auth_2 version

3.2.1

Checklist

ThexXTURBOXx commented 3 months ago

This was already addressed in 4.0.0-alpha.5