search

ThiagoBarradas / serilog-sinks-newrelic-logs

A Serilog sink that writes events to the NewRelic Logs.
https://www.nuget.org/packages/Serilog.Sinks.NewRelic.Logs
Other
31 stars 15 forks source link

Serilog upgrade >=3.0 causes exception to be thrown #17

Closed dallasbeek closed 5 months ago

dallasbeek commented 6 months ago

Status

BUG REPORT

Steps

Getting an exception likely caused by Serilog upgrade.

It looks like Serilog marked PeriodicBatchingSink class as sealed

public sealed class PeriodicBatchingSink : ILogEventSink, IDisposable

Actual behaviour

Unhandled exception. System.TypeLoadException: Could not load type 'Serilog.Sinks.NewRelic.Logs.NewRelicLogsSink' from assembly 'Serilog.Sinks.NewRelic.Logs, Version=1.2.0.0, Culture=neutral, PublicKeyToken=null' because the parent type is sealed. at Serilog.NewRelicLoggerConfigurationExtensions.NewRelicLogs(LoggerSinkConfiguration loggerSinkConfiguration, String endpointUrl, String applicationName, String licenseKey, String insertKey, LogEventLevel restrictedToMinimumLevel, Int32 batchSizeLimit, Nullable`1 period)

Environment

Running as Docker Image on Linux.

<PackageReference Include="Seq.Api" Version="2024.2.0" />
<PackageReference Include="Serilog.AspNetCore" Version="8.0.1" />
<PackageReference Include="Serilog.Enrichers.AssemblyName" Version="2.0.0" />
<PackageReference Include="Serilog.Enrichers.CorrelationId" Version="3.0.1" />
<PackageReference Include="Serilog.Enrichers.Environment" Version="2.3.0" />
<PackageReference Include="Serilog.Enrichers.MassTransit" Version="2.0.4" />
<PackageReference Include="Serilog.Settings.Configuration" Version="8.0.0" />
<PackageReference Include="Serilog.Sinks.Console" Version="5.0.1" />
<PackageReference Include="Serilog.Exceptions" Version="8.4.0" />
<PackageReference Include="Serilog.Extensions.Logging" Version="8.0.0" />
<PackageReference Include="Serilog.Sinks.NewRelic.Logs" Version="1.2.0" />
<PackageReference Include="Serilog.Sinks.Seq" Version="7.0.0" />
dallasbeek commented 6 months ago

more info here. Looks like an intentional change on their part :(

https://github.com/serilog/serilog-sinks-periodicbatching/issues/74

nblumhardt commented 6 months ago

See also #16, which is the fix for this.

dallasbeek commented 5 months ago

Confirm Fixed..ty