ThiagoFerrao / solum

APIs for OEMs to Create Standalone Applications
https://www.clarius.com
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Uncompressed 8-bit format produces a lot of haze at the bottom of the image #3

Open ujrm opened 3 months ago

ujrm commented 3 months ago

Describe the bug There's a lot of haze towards the bottom of the image (see attached screenshot).

To Reproduce Steps to reproduce the behavior:

  1. Tap Download scanner info
  2. Enable Bluetooth searching
  3. Select probe
  4. Tap Load Selected Scanner Details
  5. Connect to probe's WiFi
  6. Tap Connect
  7. Change Application to "msk"
  8. Tap Load Application
  9. Tap Run Imaging

It's also like this if you:

  1. Select "auto-gain" parameter
  2. Change value to 0
  3. Tap "Set"

Environment:

Screenshot 2024-06-25 at 15 55 46

clariusk commented 3 months ago

This seems like normal noise from having a higher gain - I do not believe this is an artefact from outside the normal image processing chain.

Further requests:

ujrm commented 3 months ago

The noise is present using Uncompressed8Bit at 50% gain with auto-gain turned off, but not when using Uncompressed with the same gain settings. The only change made was the format.

clariusk commented 3 months ago

Still not able to reproduce, images look exactly the same with L7HD3/MSK/Auto Gain Off/50% gain level, all on a high dynamic range screen

If you can post 2 raw BMP images with just changing the format, we can run some histogram analysis.

In our code, nothing changes except for a Qt library call to QImage::convertTo(QImage::Format_Grayscale8)

ThiagoFerrao commented 2 months ago

@clariusk, as you requested, some examples of images with uncompressed and uncompressed8Bit formats. I also added the images in the png format, since it is the format that we are going to use in our app.

examples.zip

clariusk commented 1 month ago

Now i have an understanding that I am not comparing image to image based on the examples, after deep diving and investigating more, this seems to be normal due to the fact that Clarius is not controlling the conversion. The Clarius App uses the XRGB data in our App an we'll convert elsewhere in the path, but never to the 8-bit format that Solum provides.

Our conversion code is using Qt library's QImage::convertTo(QImage::Format_Grayscale8) for what it's worth.