search

ThibaultBee / StreamPack

SRT/RTMP/RTMPS live streaming libraries for Android
https://thibaultbee.github.io/StreamPack/index.html
Apache License 2.0
175 stars 67 forks source link

Missing sources in the Maven Central #46

Closed jksiezni closed 1 year ago

jksiezni commented 1 year ago

The Maven Central does not provide sources artifact for the StreamPack. Could you add sources to published artifacts?

I try to implement my own ISurfaceCapture for live streaming GL-rendered content, however it is very difficult to understand hierarchy and what library classes do without sources. The Android Studio has a "Download sources" feature, but it doesn't work for your library due to missing sources artifact.

There is a stackoverflow answer that presents a simple solution to this issue: https://stackoverflow.com/questions/26874498/publish-an-android-library-to-maven-with-aar-and-sources-jar I can use it to publish sources in a local maven, but I thought it's worth sharing to help other devs too.

ThibaultBee commented 1 year ago

Hi, That's a great idea :) I will add this on my TODO list. Glad to hear someone is working on custom interfaces. This is exactly the purpose of this library. If you want to add your ISurfaceCapture in the project, I can review/accept your merge request.

BTW, if you are looking to implement your own interfaces, there are info in the DEVELOPER_README.md

Best regards, Thibault

ThibaultBee commented 1 year ago

Add in https://github.com/ThibaultBee/StreamPack/commit/9366c2162d138f4ef70d8b2467684d7198e4a95b Will be in next release.

ThibaultBee commented 1 year ago

Done in 2.4.2