search

ThibautSF / ParadoxosModManager

Software to manage mods for recent Paradox games
37 stars 6 forks source link

Choose the language of the mod configurations #1

Open NicolasGrosjean opened 7 years ago

NicolasGrosjean commented 7 years ago

Some mods are only in French, other only in English ... So give the language of a mod configuration can be useful. Besides changing the language is painful

NicolasGrosjean commented 7 years ago

We can also imagine change also other settings parameters according the mod configuration. Personally, I have no need except for languages.

NicolasGrosjean commented 7 years ago

This development seems to work only for CK2

NicolasGrosjean commented 7 years ago

The feature works for CK2 and EUIV.

I advise you to put an HOI4 and a Stellaris setting file example (like I have done for CK2 and EUIV). By this way we can test the application on games we haven't got.

ThibautSF commented 7 years ago

I will upload my test env during the lunch break (the document folder for each game with somes mods files)

ThibautSF commented 7 years ago

All my test files are uploaded ;)

Your modifications on the window make some graphic bugs : image

When you make modifications in the structure of a window i suggest you to uncomment the line "window.setGridLinesVisible(true);", it's very usefull ;)

We can return to a 0/50/50/0 column to have all center again. And modify like this : image

The other solution if we want to keep this actual design is to split the third column in two to have : 0/50/20/30/0 for GridPane : Title take 50, Help text take 20+30 Description take 50+20, Language take 30

NicolasGrosjean commented 7 years ago

Thanks for the tip to display the grid. It was the first time I have edited a Java FX code, and I have had some difficulties.

I have changed the GridPane at last and I have not seen all the impacts, sorry. The help is more visible on my dekstop (I have not the same OS), the 2nd line have no "..." but the first has. The "cancel" and "save" button are not centred.

I prefer your first option, an help button [?] is more explicit than a raw text.

NicolasGrosjean commented 7 years ago

I am not content of the help button I have done. You are free to improve it or gives me some advices.

ThibautSF commented 7 years ago

I had a column because working with only Vbox and Hbox is very painful... (that's why i migrate to GridPane all windows ^^)

Now the "?" button show immediately the tooltip when the mouse is over (don't like the default delay which cannot be modified ^^)

ThibautSF commented 7 years ago

Just modify the String "Language" to "Game Language".

NicolasGrosjean commented 7 years ago

Good job.

Like the language in the Stellaris and HoI4 settings file is the same than the EUIV one, the development works.

The last idea I had, was to display the language with a flag icon before the mod configuration name. Like it is very minor and I have few time, I have forgotten this.

If for you this development is done, you can close this issue.

ThibautSF commented 7 years ago

I reopen because i think that we should add the option to not change game language. (it can be done for the 0.4.1 or we wait to push 0.4.0)

Select is set on DEFAULT which don't modify the language in the settings.txt (in this case the ModList should be printed without the ": Language")

NicolasGrosjean commented 7 years ago

In fact I have coded it to use a default language but the default is English because I have not coded a method to read the language of the settings file. If the users play in another language than English, they need to manually change their mod configurations.

ThibautSF commented 5 years ago

I re-open the issue, for the same reason. We should have as default option the fact that game language is not edited by PMM. Don't change the value in settings.txt (pdx_settings for Imperator Rome).

Option name ie: