search

ThibautSF / ParadoxosModManager

Software to manage mods for recent Paradox games
37 stars 6 forks source link

[Important] Change window structure (ListManager) #5

Closed ThibautSF closed 7 years ago

ThibautSF commented 7 years ago

Like i do for the ListCreator window, migrate the ListManager widow structure from BorderPane to GridPane before adding new content in this window.

The GridPane object have a better responsive and resize logic and make more complex window structure much easier to create and design.

ThibautSF commented 7 years ago

WIP

image

ThibautSF commented 7 years ago

I push a stable work.

But there is still a bug with resize of lists (height) for both list management and list creator windows.

NicolasGrosjean commented 7 years ago

How have you pushed this? Directly on github? By using a desktop application like GitHub Desktop? Because my commits have disappeared, it is very strange

ThibautSF commented 7 years ago

What ? Oo I push ListManager but before i do any change i download the updated file with your modifications... A bug in EGit...

ThibautSF commented 7 years ago

It should be corrected.

I use EGit which is a good addon for eclipse... but the error reporting is not very good... so i don't see the errors caused by a bad parameter of fetch config...

NicolasGrosjean commented 7 years ago

When I have synchronized GitHub Desktop (it makes a pull and push), it has reintroduced my changes.

I think that in fact, they have not disappeared with a bug with Egit. The development branches are the following. image When you push, we see only your branch (the blue one) because the branch (in fact it is a pointer on a commit) was on your branch and you have not merged my branch. When you pull, you fetch (get all the commits from the remote repository) and you merge your local branch to the remote one.

To conclude