search

Thibauth / python-pushover

Comprehensive bindings and command line utility for the Pushover notification service
GNU General Public License v3.0
182 stars 53 forks source link

request to add expire parameter to command line pushover #20

Closed mhaeberli closed 6 years ago

mhaeberli commented 7 years ago

Thanks for the pushover python etc interface!

Since priority can be set to 2, where expire value must be set (according to error message), it would be good to add an expire argument to the command line interface.

I may make an attempt at this and subbmit a pull request ...

Thibauth commented 7 years ago

Thanks! I agree that it would be useful to have an optional "expire" argument to the command line interface. I will gladly accept a pull request for this, if you submit one. Otherwise, I might have time to work on it a bit later (maybe towards the end of next week).

mhaeberli commented 7 years ago

Thibaut, Thank you! If I get to it first, I'll send a pull request. Merçi Biens Martin

Post Script : - one thought I had was, IF priority == 2, THEN set a default expire, say, to 120, unless expire already passed in as a value on command line.

On Sun, Aug 27, 2017 at 6:59 AM, Thibaut Horel notifications@github.com wrote:

Thanks! I agree that it would be useful to have an optional "expire" argument to the command line interface. I will gladly accept a pull request for this, if you submit one. Otherwise, I might have time to work on it a bit later (maybe towards the end of next week).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Thibauth/python-pushover/issues/20#issuecomment-325200094, or mute the thread https://github.com/notifications/unsubscribe-auth/AAh_NuVi-7egAdbTYEEDBPLPkC06gfxFks5scXZQgaJpZM4PDs-A .

copart commented 6 years ago

mhaeberli , I sent in a pull request for this. It appears you also need retries set as well.

mhaeberli commented 6 years ago

thx

On Thu, Dec 28, 2017 at 5:58 PM, copart notifications@github.com wrote:

mhaeberli , I sent in a pull request for this. It appears you also need retries set as well.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Thibauth/python-pushover/issues/20#issuecomment-354386691, or mute the thread https://github.com/notifications/unsubscribe-auth/AAh_NnRh21pAQUoJtgGIkBpdFTGOBZ66ks5tFEdHgaJpZM4PDs-A .

Thibauth commented 6 years ago

Sorry for the long delay! This was solved nicely by @copart's pull request #22 and will be included in the next release. If you want to update your local version with this fix, you should run something like:

pip install --upgrade git+https://github.com/Thibauth/python-pushover