Thibauth / python-pushover

Comprehensive bindings and command line utility for the Pushover notification service
GNU General Public License v3.0
182 stars 53 forks source link

Could you do a release with the image attachments? #25

Closed rwifall closed 6 years ago

rwifall commented 6 years ago

A new release that includes the image attachments functionality would be useful.

brandonscript commented 6 years ago

Would love some documentation on how to use it too - took me a while to figure out I needed to do attachment = ("image.jpg", open(img, "rb"), "image/jpeg") instead of just passing a file path.

brandonscript commented 6 years ago

Bump...

dchevell commented 6 years ago

@brandonscript the simple way to use it is to pass any file-like object via the attachment keyword when sending a message.

messenger = pushover.Client(PUSHOVER_USER_KEY, api_token=PUSHOVER_API_TOKEN)

with open('/path/to/my/image.png', 'rb') as image:
    messenger.send_message('Test message with image', attachment=image)
brkr19 commented 6 years ago

Hi, would it be possible to include this functionality into a 0.4 release? I see the functionality was added in pull #24, but I don't see it bundled as a release. I'm working on some changes for the Home Assistant project that could greatly benefit from this functionality. I'd be happy to help if there's anything that's needed. Thanks!

dchevell commented 6 years ago

@Thibauth ^

fabaff commented 6 years ago

This is blocking https://github.com/home-assistant/home-assistant/pull/13748.

Thibauth commented 6 years ago

Thanks everyone and sorry for the delay, I should be able to do this in the next couple of days.

dchevell commented 6 years ago

@Thibauth let me know if I can help in a more general fashion with this project, if there is basic maintenance / release work I can do, or if I can help with automating deployment of new releases etc.

Thibauth commented 6 years ago

I just did a new release (0.4) with the attachment feature. Thanks again for the help and sorry for the delay. Please let me know if anything is broken.

@chevell I would be happy to give you access to the repository if you think you could help with general maintenance.

rwifall commented 6 years ago

Thanks