search

Thie1e / cutpointr

Optimal cutpoints in R: determining and validating optimal cutpoints in binary classification
https://cran.r-project.org/package=cutpointr
86 stars 13 forks source link

Update of benchmark results #20

Closed xrobin closed 5 years ago

xrobin commented 5 years ago

Hi,

As promised in issue #19 here is an update of the benchmark data with the latest pROC from GitHub. This version is not available on CRAN yet, I am planning to release it by the end of the month.

Please do not attempt to run the benchmark with pROC 1.14.0 or earlier, they would not complete in a reasonable time with the call to coords. This also means it's probably best not to merge this pull request quite yet :) But I hope you can give it a look already so that I can change things if you want to.

Note that the benchmarks were run with the current CRAN version of all the other packages, R 3.5.0, on an Intel Core i7-6700 running CentOS 7.6.1810.

Thie1e commented 5 years ago

Hi, thanks a lot. The changes look fine. Is it possible to change the target from master to the branch update_benchmark? I could merge the changes into that branch for now.

xrobin commented 5 years ago

Here you go!

Thie1e commented 5 years ago

Thanks! I'm going to merge this branch into master when the new version of pROC is on CRAN (possibly after adding memory benchmarks).