search

Thie1e / cutpointr

Optimal cutpoints in R: determining and validating optimal cutpoints in binary classification
https://cran.r-project.org/package=cutpointr
85 stars 13 forks source link

dplyr 1.0.0 compatibility #27

Closed hadley closed 4 years ago

hadley commented 4 years ago

The first commit introduces the methods needed to make dplyr::bind_rows() and friends work without warnings. This depends on the development version of vctrs, and it's likely it will change, in the future, but at least makes it possible to run the tests.

The second commit is the meaningful change for dplyr 1.0.0 compatibility — dplyr now always preserves the names of atomic vectors which caused a few test failures.

Thie1e commented 4 years ago

Thank you, this is very helpful. I was just working on an update to establish compatibility with the upcoming vctrs 0.3.0. I'm going to merge the pull request and then tweak my code as necessary.