search

ThiefMaster / pyquotes

A tool that ensures consistent string quotes in your Python code.
MIT License
9 stars 0 forks source link

click dependency not bounded #3

Open ghost opened 2 years ago

ghost commented 2 years ago

OS: Windows 10 21H2 Python: Python 3.10.4

Steps:

example.py

print("Hello, World!")

pyquotes --check example.py pyquotes -D --check example.py

Both fail with the error

  File "C:\Python310\lib\site-packages\pyquotes\settings.py", line 96, in __init__
    super().__init__(**settings, project_root=project_root)
TypeError: _Config.__init__() got an unexpected keyword argument 'check'

This is resolved when using click>=8.

Thank you for your time, this library has saved my many hours.

ThiefMaster commented 2 years ago

Thanks, but I do not plan to support click 6. It's ancient (5 years old).

If there's a problem with recent click versions (7 or 8) that'd be something more worth fixing (ideally supporting both).

ghost commented 2 years ago

Thanks, but I do not plan to support click 6. It's ancient (5 years old).

If there's a problem with recent click versions (7 or 8) that'd be something more worth fixing (ideally supporting both).

Absolutely correct, but could you put a requirement on >=8? (the issue happens on 7.x as well) incase someone's environment has click already installed, it's currently an unbounded requirement.

Edit: Apologies, the issue isn't present on 7.x, so could requirements be updated to >=7 **