ThierryHFR / Big-Sur-StatusArea

macOS Big Sur "System Tray" look for Gnome Desktop
https://www.pling.com/p/1427290/
26 stars 4 forks source link

Requests: Remove Airplane Icon When Ethernet Is Active, Offer Possibility To Hide Airplane Icon/Mode #44

Closed jacob-emery closed 2 years ago

jacob-emery commented 3 years ago

Would it be possible to hide the airplane icon from the network indicator when an Ethernet connection is active (with WiFi and Bluetooth disabled)? In this case an airplane icon is added alongside the Ethernet icon, and it feels a bit weird. Would it be possible to also remove "Airplane Mode On" from the Network indicator?

Actually, I would completely remove the text "Airplane Mode On" from the Network indicator at all times, even when there is no active Ethernet connection. In the case of no WiFi, no Ethernet and no Bluetooth the Airplane Icon should still be displayed, but the text should be removed if you expand the indicator.

You could offer an option in the settings (for instance "Disable Airplane Mode") if you don't want this to be the default.

ThierryHFR commented 3 years ago

hi @jacob-emery, Can you tell me the version of the extension you use?

jacob-emery commented 3 years ago

It is version 23. The current one from https://extensions.gnome.org/.

I took a screenshot with wifi and bluetooth both disabled. Screenshot from 2021-06-17 22-20-45

ThierryHFR commented 3 years ago

I need to know what version of gnome-shell you are running. gnome-shell 3.38 uses Gtk 3 gnome-shell 40.x uses Gtk 4 Your distribution, etc... I need to know your context to be able to reproduce and correct! Thanks Thierry

jacob-emery commented 3 years ago

Actually, I don't even consider this to be an issue anymore. It felt weird at first to see two icons inside the network indicator, but I already got used to it. Seeing the airplane also tells me that the WiFi is disabled (i.e. that I am using only an Ethernet cable).

However, I think it would be much clearer for the average person if:

With this changes one will not need to look at the airplane icon and say "mmmh... does that mean that bluetooth and wifi are disabled?" — instead it will be completely clear. Especially for people that don't understand IT very well (I am planning to install this extension on my family members' PCs).

jacob-emery commented 3 years ago

I use Fedora 33 with the latest GNOME 3.38.x packages.

jacob-emery commented 3 years ago

Since I am in the middle of my exams' session, for three more weeks I will not be able to test on Fedora 34 (Gnome 40.x). But I'll do it as soon as I can :)

jacob-emery commented 3 years ago

Thank you for considering my proposal! However, if some object pieces are hard coded also in this case and they would make he extension impossible to maintain... then never mind. Thank you for offering us this great extension.

ThierryHFR commented 3 years ago

I have reproduced, thank you, I will try to correct!

ThierryHFR commented 3 years ago

Hi @jacob-emery, It is corrected, you must wait for the publication by gnome-extensions of the new extensions, I let you close the issue, if it is corrected!

ThierryHFR commented 3 years ago

The publication was faster than expected :grin:

jacob-emery commented 3 years ago

Unfortunately I can still see the airplane icon Screenshot from 2021-06-18 11-10-40

jacob-emery commented 3 years ago

I had a very quick look at the code and it appears to me that this._network._primaryIndicator.visible only considers the wifi interface. I could be wrong though.

I propose to leave this issue open for another 3 weeks and then, once I am finished with my exams, I'd love to help you debug and adjust the code for a better user experience.

ThierryHFR commented 3 years ago

Ok for me and good luck with your examuns!

ThierryHFR commented 2 years ago

No feedback

jacob-emery commented 2 years ago

Sorry, I forgot to give feedback. I tried to fix it, but without success. I should have closed the issue a long time ago...