Closed jacob-emery closed 2 years ago
hi @jacob-emery, Can you tell me the version of the extension you use?
It is version 23. The current one from https://extensions.gnome.org/.
I took a screenshot with wifi and bluetooth both disabled.
I need to know what version of gnome-shell you are running. gnome-shell 3.38 uses Gtk 3 gnome-shell 40.x uses Gtk 4 Your distribution, etc... I need to know your context to be able to reproduce and correct! Thanks Thierry
Actually, I don't even consider this to be an issue anymore. It felt weird at first to see two icons inside the network indicator, but I already got used to it. Seeing the airplane also tells me that the WiFi is disabled (i.e. that I am using only an Ethernet cable).
However, I think it would be much clearer for the average person if:
the airplane mode icon should not shown at all. Only exception: ethernet cable disconnected and wifi turned off (we don't care about bluetooth) -- This suggestion already takes place, except for when plugging in an ethernet cable (in that case the airplane mode icon should disappear)
bluetooth icon needs to be disabled when bluetooth is disabled (point made already in the other request)
wifi icon is not shown if it is disabled (instead the airplane mode icon is shown if there is no active ethernet connection either, else the ethernet icon is shown) -- This suggestion already takes place, no need to change anything. The idea would help draw a line between wifi disabled (this case) and wifi not connected to any network.
wifi that is turned on but there is no active WiFi connection should display the "empty WiFi" icon on top. However, right now the airplane mode is displayed on top (which is not ideal because someone might think that the interface is turned off). The idea would help draw a line between wifi disabled and wifi not connected to any network (this case).
if ethernet and wifi are enabled at the same time, you should see them both on the top bar (right now one can see only the ethernet icon, the wifi icon is seen only if expanding the network indicator) -- (in other words, the functionality should be similar to what happens already when turning on the VPN: a VPN icon is displayed. And if I turn that VPN connection off, the VPN icon disappears, but it still possible to enable again if the network indicator is expanded). This last point is important so one knows if they are using more than one interface to connect to the internet.
With this changes one will not need to look at the airplane icon and say "mmmh... does that mean that bluetooth and wifi are disabled?" — instead it will be completely clear. Especially for people that don't understand IT very well (I am planning to install this extension on my family members' PCs).
I use Fedora 33 with the latest GNOME 3.38.x packages.
Since I am in the middle of my exams' session, for three more weeks I will not be able to test on Fedora 34 (Gnome 40.x). But I'll do it as soon as I can :)
Thank you for considering my proposal! However, if some object pieces are hard coded also in this case and they would make he extension impossible to maintain... then never mind. Thank you for offering us this great extension.
I have reproduced, thank you, I will try to correct!
Hi @jacob-emery, It is corrected, you must wait for the publication by gnome-extensions of the new extensions, I let you close the issue, if it is corrected!
The publication was faster than expected :grin:
Unfortunately I can still see the airplane icon
I had a very quick look at the code and it appears to me that this._network._primaryIndicator.visible
only considers the wifi interface. I could be wrong though.
I propose to leave this issue open for another 3 weeks and then, once I am finished with my exams, I'd love to help you debug and adjust the code for a better user experience.
Ok for me and good luck with your examuns!
No feedback
Sorry, I forgot to give feedback. I tried to fix it, but without success. I should have closed the issue a long time ago...
Would it be possible to hide the airplane icon from the network indicator when an Ethernet connection is active (with WiFi and Bluetooth disabled)? In this case an airplane icon is added alongside the Ethernet icon, and it feels a bit weird. Would it be possible to also remove "Airplane Mode On" from the Network indicator?
Actually, I would completely remove the text "Airplane Mode On" from the Network indicator at all times, even when there is no active Ethernet connection. In the case of no WiFi, no Ethernet and no Bluetooth the Airplane Icon should still be displayed, but the text should be removed if you expand the indicator.
You could offer an option in the settings (for instance "Disable Airplane Mode") if you don't want this to be the default.