search

ThierryHFR / Big-Sur-StatusArea

macOS Big Sur "System Tray" look for Gnome Desktop
https://www.pling.com/p/1427290/
26 stars 4 forks source link

Notifications icon has red status icon #48

Closed marcinjahn closed 2 years ago

marcinjahn commented 2 years ago

I'm seeing this: image

I have no notifications at the moment. Shouldn't the red circle disappear?

ThierryHFR commented 2 years ago

You don't give enough detail about your system! Which version of gnome-shell are you using? What version of the extension do you have?

marcinjahn commented 2 years ago

Sorry, here it is: Fedora 35 Gnome 41.1 Extension V27

Screenshot with notifications open: image

ThierryHFR commented 2 years ago

I look in the weekend, I do not have your version! indeed the red circle should not be visible!

marcinjahn commented 2 years ago

I installed it from the Gnome Extensions website.

ThierryHFR commented 2 years ago

I can imagine. I use the icons of your theme. and usually this problem is there when the theme does not provide all the icons...

kcken commented 2 years ago

This started with the new version of Gnome and Fedora 35. This worked fine in Fedora 34 (with the same theme applied). Something changed in how the shell is picking icons because my volume icon disappeared as well.

marcinjahn commented 2 years ago

@kcken My volume icon is fine: image

kcken commented 2 years ago

Turned out my volume icon was due to a Fedora update that broke audio (problem with upgrading from 34 to 35 and the audio subsystem change) - fixed that now, and the volume icon is back. With regards to the problem with notifications - I fixed it in notifications.js - I changed:

const NoNotifications = 'task-past-due-symbolic'; const NewNotifications = 'task-due-symbolic';

to

const NoNotifications = 'task-none-symbolic'; const NewNotifications = 'task-due-symbolic';

I then created a task-none-symbolic icon (attached) and placed it in the same directory as task-due-symbolic which on my system was ~/.icons/BigSur/status/symbolic

With this change, when there are no notifications, the clipboard is blank.

Another option would be to use the 2 existing notification icons "notification-symbolic" and "notification-new-symbolic" as those already exist, and properly show the state of existing notifications (on my system those are a bell icon as opposed to a clipboard icon)

const NoNotifications = 'notification-symbolic'; const NewNotifications = 'notification-new-symbolic';

Anyway, hope this helps!

task-none-symbolic.zip

ThierryHFR commented 2 years ago

Hi @kcken, Thanks for the feedback, I will make a mix of all of these! The icons are theme dependent, I took the option to remove the extension icons to use the system one provided by the theme. We all have a different distribution or theme. Your feedback brings me a lot, are you able to propose a pull-request ?

luca-martino commented 2 years ago

On my environment the "notification-symbolic" and "notification-new-symbolic" are more consistent.

const NoNotifications = 'notification-symbolic'; const NewNotifications = 'notification-new-symbolic';

kcken commented 2 years ago

I made the same change:

@.*** indicators]$ diff notification.js notification.js.orig 28,29c28,29 < const NoNotifications = 'notification-symbolic'; < const NewNotifications = 'notification-new-symbolic';

const NoNotifications = 'task-past-due-symbolic'; const NewNotifications = 'task-due-symbolic';

On Mon, Feb 14, 2022 at 2:55 AM luca-martino @.***> wrote:

On my environment the "notification-symbolic" and "notification-new-symbolic" are more consistent.

const NoNotifications = 'notification-symbolic'; const NewNotifications = 'notification-new-symbolic';

— Reply to this email directly, view it on GitHub https://github.com/Ordissimo/Big-Sur-StatusArea/issues/48#issuecomment-1038763823, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADLNLL6DKU4Z4NSLXDCLENDU3CYQXANCNFSM5HNPICSA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

ThierryHFR commented 2 years ago

Hi All, Some functions are not working since the migration to the new gnome-shell formalism. This generates a lot of feedback from you (all), I'm solving this problem as a priority ! I'll work on your problem in the next days, but I can't change the icons as you suggest, the solution must be global and not only turned to your distribution.

kem-a commented 2 years ago

On my environment the "notification-symbolic" and "notification-new-symbolic" are more consistent.

const NoNotifications = 'notification-symbolic'; const NewNotifications = 'notification-new-symbolic';

What is your environment? Can you be more specific. OS:? gnome-shell:? Wayland | X11:? Default theme? Default icons?

luca-martino commented 2 years ago

On my environment the "notification-symbolic" and "notification-new-symbolic" are more consistent. const NoNotifications = 'notification-symbolic'; const NewNotifications = 'notification-new-symbolic';

What is your environment? Can you be more specific. OS:? gnome-shell:? Wayland | X11:? Default theme? Default icons?

OS: Fedora release 35 DE: GNOME 41.4 X11 Theme: WhiteSur-dark Icons: WhiteSur-dark ... but with latest release of Big-Sur-StatusArea 3c1e253 it's ok

ThierryHFR commented 2 years ago

Thanks for the feedback and thanks for the contribution of @AI-ien!