Make gtk theme set indicator dimensions

[SaucySauce]

Instead of having to manually specify indicator padding every time to match the theme in use, allow for the indicators to follow the gtk theme standards.

Present here is the color picker indicator, kstatus indicator for 3rd party app indicators (Telegram shown here), clipboard indicator, pamac updates indicator, screenshot tool indicator, and your extension indicators. If I were to switch to a different theme, all indicators except yours would follow the theme's padding automatically.

[ThierryHFR]

Indeed, it would be more fun! You have opened a lot of issues, I will try to solve each problem if it is relevant. But it's been a week since I discovered this project so please be understanding :)

[SaucySauce]

Thank you. You're doing amazing work. I tried forking panel-indicators to work on 3.38 a while ago but never could get it to work. You made it work really well.

[ThierryHFR]

Can you look at this branch desactivate-spacing ? It allows to disable the space setting. Need to restart gnome shell for the right visual, I continue to work on it

[SaucySauce]

So far it works well. Only thing that doesn't work is that setting a custom padding and then disabling it it doesn't update to the theme padding.

[SaucySauce]

Ok this is weird. I'm scanning all the extensions I have and the indicators have two size standards, one 2 pixels less than the other. Your extension uses the smaller of the two standards.

Top network indicator is manually adjusted to the bigger standard. Bottom is automatic.

[ThierryHFR]

So far it works well. Only thing that doesn't work is that setting a custom padding and then disabling it it doesn't update to the theme padding.

Yes, I need to see, to go through all the indicators and find the style applied to each.

[ThierryHFR]

Can you comment this in the stylesheet.css file ?

/*.panel-status-menu-box>StIcon { 
    icons-size: 16px; padding: 4px;
}*/

Is this suitable?

[ThierryHFR]

Le 2021-03-23 01:00, SaucySauce a écrit :

So far it works well. Only thing that doesn't work is that setting a custom padding and then disabling it it doesn't update to the theme padding.

Also, how do I stop the extensions app from forcing update?

rename the folder and the uuid of metadata.json with the same name

[1]

-- You are receiving this because you commented. Reply to this email directly, view it on GitHub [2], or unsubscribe [3].

Links:

[1] https://user-images.githubusercontent.com/38703177/112072856-4b38c680-8b62-11eb-8ad0-d2bdb507c19d.png [2] https://github.com/Ordissimo/Big-Sur-StatusArea/issues/5#issuecomment-804479622 [3] https://github.com/notifications/unsubscribe-auth/ACRQEDGNL2WSD2JNP26PQQLTE7KYDANCNFSM4ZR4FFBA

[SaucySauce]

Ok, so it updates the padding when enabling/disabling the manual overwrite. BUT manually setting the padding doesn't work anymore and sets to 0px. On my end it's ok as automatic padding does the work just fine.

[SaucySauce]

Can you comment this in the stylesheet.css file ?

/*.panel-status-menu-box>StIcon { 
    icons-size: 16px; padding: 4px;
}*/

Is this suitable?

Comment on what exactly?

[ThierryHFR]

Comment on this:

.panel-status-menu-box>StIcon { 
    icons-size: 16px; padding: 4px;
}

in this file: https://github.com/Ordissimo/Big-Sur-StatusArea/blob/master/stylesheet.css

[SaucySauce]

I changed padding: to 5px

[SaucySauce]

Now it's set to the bigger padding standard. the one 2px wider I mentioned from above.

[ThierryHFR]

I am not good in English, can you give me more precision?

Ok, so it updates the padding when enabling/disabling the manual overwrite. BUT manually setting the padding doesn't work anymore and sets to 0px. On my end it's ok as automatic padding does the work just fine.

[SaucySauce]

Ok so now everything is perfect.

[SaucySauce]

I am not good in English, can you give me more precision?

Ok, so it updates the padding when enabling/disabling the manual overwrite. BUT manually setting the padding doesn't work anymore and sets to 0px. On my end it's ok as automatic padding does the work just fine.

This is what I mean.

[SaucySauce]

Disabling "Activate Indicator Spacing" allows for proper automatic spacing but now manual setting is broken.

[ThierryHFR]

Inattention, thank you !

[ThierryHFR]

If it is good for you I let you close

[SaucySauce]

Ok, give me a second to review it.

[SaucySauce]

It seems like manual setting of the padding still doesn't work. Thanks for the increase in padding to 5px.

[SaucySauce]

Wait. Still running older version.

[SaucySauce]

My bad.

[ThierryHFR]

:-)

[SaucySauce]

Your latest update. Nice. Thanks.

[SaucySauce]

Manual padding works perfectly fine.

[SaucySauce]

I think it's stable and good for Issue to be closed.