ThierryHFR / Big-Sur-StatusArea

macOS Big Sur "System Tray" look for Gnome Desktop
https://www.pling.com/p/1427290/
26 stars 4 forks source link

Make calendar indicator show all when notifications indicator is disabled. #6

Closed SaucySauce closed 3 years ago

SaucySauce commented 3 years ago

Screenshot from 2021-03-21 18-42-54

As shown here, notifications indicator is disabled yet the calendar notification still acts as if notifications were being handled by another indicator. Also, the padding on the left border of the widget is too small compared to the right side.

ThierryHFR commented 3 years ago

I have the same margins before and after activation of the extension.

Capture d’écran du 2021-03-21 21-47-26 Capture d’écran du 2021-03-21 21-46-30

SaucySauce commented 3 years ago

No, I mean, disabling just the notifications indicator. Screenshot from 2021-03-21 19-53-14

ThierryHFR commented 3 years ago

I don't understand the problem .... If you have more precision?

SaucySauce commented 3 years ago

if big-sur-notifications-indicator.toggle: on, big-sur-calendar-indicator: enable;

else stock-calendar/notifications: enable;

ThierryHFR commented 3 years ago

Ok, I will correct this tonight!

SaucySauce commented 3 years ago

Screenshot from 2021-03-26 21-11-08

What did you do? I see no change.

SaucySauce commented 3 years ago

This is what I mean Screenshot-20210326211507-954x120 when it is like this

The calendar should look like this (default gnome behavior) pic_5

ThierryHFR commented 3 years ago

Ok, I didn't understand! I have disabled system notifications as soon as you disable notifications. As for what you want, it is to reintegrate the notifications in the calendar indicator, it can be done, but it is a feature and not a bug! I'll look at how to do this in a way that preserves the native behavior, but also allows flexibility!

SaucySauce commented 3 years ago

Thanks. Yeah, I should've made my statements easier to understand. Sorry about that.

ThierryHFR commented 3 years ago

Hi @SaucySauce ,Here is an implementation of the feature you asked for. It's not perfect, the switch between the current version and your feature forces to restart gnome-shell, I haven't found another solution yet! I took the opportunity to replace the icons by the system one. Only one icon is still a problem, the bluetooth pairing.

SaucySauce commented 3 years ago

Hi @SaucySauce ,Here is an implementation of the feature you asked for. It's not perfect, the switch between the current version and your feature forces to restart gnome-shell, I haven't found another solution yet! I took the opportunity to replace the icons by the system one. Only one icon is still a problem, the bluetooth pairing.

I'll check the code. Thanks. Also, as for the Bluetooth pairing icon issue, you can request for the bluetooth paired icon and fallback to the standard active icon in case the system doesn't have a custom icon theme that has a bluetooth-paired.

SaucySauce commented 3 years ago

Screenshot from 2021-04-03 13-33-21

Still the same.

ThierryHFR commented 3 years ago

Change branch.

git checkout asseble-date-and-notification

parametre Disable the Indicator XXXX option. Reload gnome-shell

SaucySauce commented 3 years ago

oh ok. my mistake. Will check out soon.

SaucySauce commented 3 years ago

Ok, so it semi works, messing with the order which the indicators are enabled kills the function.

What if instead, you add a new indicator (just the default gnome shell calendar, clock, weather, notifications) with the ability to be moved in the order of indicators. I think it's preferable than to having to have the two, notifications and calendar, indicators communicate.

ThierryHFR commented 3 years ago

This is not possible. The problem is that we take the elements of gnome-shell and arrange them differently. I don't play with the two indicators. I have a date indicator and the notification indicator. When you disable the separation of the indicators the date indicator is disabled and it is the notification indicator that does both. Tell me exactly what is wrong.

SaucySauce commented 3 years ago

The weather doesn't show. Toggling either the notifications or calendar indicator after it's working will instantly kill the unified widget and go back to separate widgets.

ThierryHFR commented 3 years ago

This does not work until gnome-shell is released. A gnome-shell object cannot be used in two places. I will check the weather. For the rest I can't do anything. I would have to restart the extension automatically.

ThierryHFR commented 3 years ago

Toggling either the notifications or calendar indicator after it's working will instantly kill the unified widget and go back to separate widgets.

Fixed

SaucySauce commented 3 years ago

Will verify. Thanks.

SaucySauce commented 3 years ago

It's better. Thanks.

SaucySauce commented 3 years ago

Screenshot from 2021-04-03 16-45-36

Weird bug on the indicator itself.

ThierryHFR commented 3 years ago

You talk about the date? Give details

SaucySauce commented 3 years ago

The weird gap on the right of the hour on the top bar.

ThierryHFR commented 3 years ago

The space for the notification icon

notify-send test test1
SaucySauce commented 3 years ago

Can you make it dynamic so the gap isn't always there?

ThierryHFR commented 3 years ago

Can you make it dynamic so the gap isn't always there?

Fixed

SaucySauce commented 3 years ago

Excellent. Working perfectly.

ThierryHFR commented 3 years ago

I watch tonight for the weather

SaucySauce commented 3 years ago

Thank you.

SaucySauce commented 3 years ago

https://github.com/Ordissimo/Big-Sur-StatusArea/pull/25

I did a small modification, don't know if it makes sense, Adwaita icons are pretty big but Newaita are smaller.

ThierryHFR commented 3 years ago

Can you test it?

SaucySauce commented 3 years ago

Screenshot from 2021-04-03 21-57-01 Has a blank gap underneath the weather but everything works fine.

ThierryHFR commented 3 years ago

Can you test it?

SaucySauce commented 3 years ago

working perfectly.

SaucySauce commented 3 years ago

btw, can you make the date like this? Screenshot-20210404001557-379x373 it looks so pretty.

Tuxman2 commented 3 years ago

Hi,

do you know where is defined this part (date above the calendar) in the gnome-shell.css file ? I'm searching it but I don't find it.

Thanks.

ThierryHFR commented 3 years ago

btw, can you make the date like this?

@SaucySauce, Fix with 99b26e7dcc8be72889f124d68e4fe28a63987d10

do you know where is defined this part (date above the calendar) in the gnome-shell.css file ? I'm searching it but I don't find it.

@Tuxman2, look this 99b26e7dcc8be72889f124d68e4fe28a63987d10, the day-label class and the date-label class allow to define the style of the date

SaucySauce commented 3 years ago

Sweet. everything is working and looking good. I think this branch can be merged to master unless you think you can still improve on the notifications and calendar code.