ThierryHFR / Big-Sur-StatusArea

macOS Big Sur "System Tray" look for Gnome Desktop
https://www.pling.com/p/1427290/
26 stars 4 forks source link

New notification indicators #67

Closed kem-a closed 2 years ago

kem-a commented 2 years ago

Made some changes to notifications indicators. This PR will solve confusing default clipboard icons and will add DnD:

These icons are activated for split calendar/notification case. When calendar/notifications are merged (default Gnome) then I left the same behavior as in Gnome, so the icon is a dot when there is a notification or hidden in case of no notifications, plus disabled notification icon when DnD. It's up to you to leave like this or change like in split case, but I think it is more appropriate leave like this. In any case it is easy to change.

This will also fix issue #48

ThierryHFR commented 2 years ago

Hi @AI-ien, Thank's for your work! I removed the icons from the project (https://github.com/Fausto-Korpsvart/Big-Sur-StatusArea/tree/master/icons) to use the icons provided by the systems, some users complained about the inconsistency of the icons with their theme. I would prefer the icons you provide as a fallback.

kem-a commented 2 years ago

I would agree if Adwaita had a dedicated notification icons. Who ever complained about inconsistency was wrong or was actually using custom icon pack. Currently default used icons are task-due-symbolic and task-past-due-symbolic, none is related with notifications. This actually creates the opposite effect of consistency because of confusing task icons in place of notifications.

ThierryHFR commented 2 years ago

Thanks for the contribution!

ThierryHFR commented 2 years ago

Hi @AI-ien , I like it very much!

kem-a commented 2 years ago

Somehow update v34 pushed without icons.

ThierryHFR commented 2 years ago

@AI-ien, Fixed in v35 0ed395c